From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org,
Heinz Mauelshagen <heinzm@redhat.com>
Subject: Re: dm raid: pointer math issue in super_sync()
Date: Tue, 21 Oct 2014 15:57:29 +0300 [thread overview]
Message-ID: <20141021125729.GC26918@mwanda> (raw)
In-Reply-To: <20141021124826.GC20625@redhat.com>
On Tue, Oct 21, 2014 at 08:48:26AM -0400, Mike Snitzer wrote:
> > - memset(sb + sizeof(*sb), 0, rdev->sb_size - sizeof(*sb));
> > + memset(sb + 1, 0, rdev->sb_size - sizeof(*sb));
> >
> > sb->magic = cpu_to_le32(DM_RAID_MAGIC);
> > sb->features = cpu_to_le32(0); /* No features yet */
>
> Not following... sizeof(*sb) != sizeof(sb). So I'm not seeing a
> problem.
>
> Nor am I seeing how you think sb + 1 is equivalent to what Heinz
> intended (zero the memory following the sizeof(struct dm_raid_superblock)).
It's pointer math.
sizeof(*sb) is 512.
"sb + sizeof(*sb)" is the same as (void *)sb + 512 * 512.
"sb + 1" is the same as (void *)sb + 512.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-21 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:43 [patch] dm raid: pointer math issue in super_sync() Dan Carpenter
2014-10-21 12:48 ` Mike Snitzer
2014-10-21 12:57 ` Dan Carpenter [this message]
2014-10-21 13:25 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021125729.GC26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).