From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 5/8 v2] dm: replace memset by memzero_explicit
Date: Mon, 1 Dec 2014 18:00:38 -0500 [thread overview]
Message-ID: <20141201230037.GA9761@redhat.com> (raw)
In-Reply-To: <547CD7B9.5030000@gmail.com>
On Mon, Dec 01 2014 at 4:03pm -0500,
Milan Broz <gmazyland@gmail.com> wrote:
> On 11/30/2014 06:03 PM, Julia Lawall wrote:
> > From: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > Memset on a local variable may be removed when it is called just before the
> > variable goes out of scope. Using memzero_explicit defeats this
> > optimization. A simplified version of the semantic patch that makes this
> > change is as follows: (http://coccinelle.lip6.fr/)
>
> Ack, but I submitted the same patch a week ago....
>
> https://www.redhat.com/archives/dm-devel/2014-November/msg00084.html
>
> Mike, please could you add this to linux-next tree or you want this
> to go through Herbert's tree?
> (I do not think it is good idea for DM patches.)
I staged it in linux-next for 3.19 inclusion, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-for-3.19&id=a722201f9075b28be140bc13f8ec07bf6a42edd4
prev parent reply other threads:[~2014-12-01 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 17:03 [PATCH 0/8] replace memset by memzero_explicit Julia Lawall
2014-11-30 17:03 ` [PATCH 5/8 v2] dm: " Julia Lawall
2014-12-01 21:03 ` Milan Broz
2014-12-01 23:00 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201230037.GA9761@redhat.com \
--to=snitzer@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).