From: NeilBrown <neilb@suse.de>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c
Date: Thu, 18 Dec 2014 10:19:06 +1100 [thread overview]
Message-ID: <20141218101906.55b7772d@notabene.brown> (raw)
In-Reply-To: <1418831373-18415-1-git-send-email-xerofoify@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
On Wed, 17 Dec 2014 10:49:33 -0500 Nicholas Krause <xerofoify@gmail.com>
wrote:
> Removes the no longer needed fix me comment related to not needing the agrument faster for the function,
> sync_request. Due to getting warnings when building without the agrument it seems that this fix me was
> wrong and we must keep this agrument in order to avoid build warnings when building without it.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/md/raid5.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index c1b0d52..c0fde2a 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4986,7 +4986,6 @@ ret:
> return reshape_sectors;
> }
>
> -/* FIXME go_faster isn't used */
> static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int *skipped, int go_faster)
> {
> struct r5conf *conf = mddev->private;
Why do you think the comment is no longer needed. Is "go_faster" being used
now? Is there a clear explanation somewhere of why "go_faster" should not be
used?
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next parent reply other threads:[~2014-12-17 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1418831373-18415-1-git-send-email-xerofoify@gmail.com>
2014-12-17 23:19 ` NeilBrown [this message]
2014-12-18 4:44 ` [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218101906.55b7772d@notabene.brown \
--to=neilb@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).