From: NeilBrown <neilb@suse.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/1] RFC: Use /dev/md/X as default name
Date: Thu, 19 Feb 2015 09:32:36 +1100 [thread overview]
Message-ID: <20150219093236.25660678@notabene.brown> (raw)
In-Reply-To: <wrfj61ay6fai.fsf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2738 bytes --]
On Wed, 18 Feb 2015 17:11:33 -0500 Jes Sorensen <Jes.Sorensen@redhat.com>
wrote:
> NeilBrown <neilb@suse.de> writes:
> > On Wed, 18 Feb 2015 13:12:09 -0500 Jes Sorensen <Jes.Sorensen@redhat.com>
> > wrote:
> >
> >> Jes.Sorensen@redhat.com writes:
> >> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >> >
> >> > I have received some issues for when creating an array using a
> >> > /dev/mdX name, the matching symlink in /dev/md/X isn't
> >> > created. Whereas if you create /dev/md/X, /dev/mdX is created
> >> > automatically.
> >> >
> >> > I was trying to see if there was a better way of dealing with this,
> >> > but I couldn't find one. If you have suggestions for a better solution
> >> > I am all ears.
> >> >
> >> > Thoughts?
> >>
> >> Hi Neil,
> >>
> >> Any thoughts on this one?
> >
> > Thanks for the reminder....
> >
> > I'm not sure that I really see the problem.
> >
> > "I ask it to create /dev/mdX and it doesn't create /dev/md/X".
> >
> > Well ... no. You didn't ask it to. If you want it to create /dev/md/X,
> > then ... ask it to.
> >
> > /dev/mdX is the canonical name. It always gets created.
> > /dev/md/X is a convenient alias. It gets created if requested.
> >
> > Is there really a problem here worth solving?
> >
> > Maybe I missed something.
>
> I have had complaints in Fedora from the installer people that they rely
> on the /dev/md/ name being created when they create a new device. It is
> also inconsistent because /dev/md/<X> will be created if you run
> 'mdadm -As' later on.
If they rely on the /dev/md/ name being created, then surely they should ask
for it to be created.
Is it really harder to run "mdadm -C /dev/md/0" than "mdadm -C /dev/md0" ??
If you create an array as "/dev/md0", then after subsequent "mdadm
-As" /dev/md0 will exist.
If you create an array as "/dev/md/0", then after subsequent mdadm
-As", /dev/md/0 will exist.
The fact that something unasked for also exists is a bonus.
>
> I don't see it as a major issue, but I can see why it is frustrating for
> some and I think there is something to be said for being consistent in
> behavior.
I think the behaviour is perfectly consistent. It just follows rules that
are slightly less trivial that some people appear to want.
However....
If you changed
mp = map_by_uuid(&map, info->uuid);
if (mp && mp->path &&
strncmp(mp->path, "/dev/md/", 8) == 0) {
printf("MD_DEVNAME=");
print_escape(mp->path+8);
putchar('\n');
}
in Detail.c so that when mp->path were "/dev/md0", MD_DEVNAME became "0",
then you should get the result that you are after, and I probably wouldn't
object to the patch.
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-02-18 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 19:53 [PATCH 0/1] RFC: Use /dev/md/X as default name Jes.Sorensen
2015-02-11 19:53 ` [PATCH 1/1] mddev_create(): choose /dev/md/ name over /dev/mdX Jes.Sorensen
2015-02-18 18:12 ` [PATCH 0/1] RFC: Use /dev/md/X as default name Jes Sorensen
2015-02-18 21:37 ` NeilBrown
2015-02-18 22:11 ` Jes Sorensen
2015-02-18 22:32 ` NeilBrown [this message]
2015-03-02 16:32 ` Jes Sorensen
2015-03-02 21:43 ` NeilBrown
2015-03-04 15:57 ` Jes Sorensen
2015-03-05 14:56 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219093236.25660678@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).