From: Tejun Heo <tj@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Prakash Punnoor <prakash@punnoor.de>,
Torsten Kaiser <just.for.lkml@googlemail.com>,
linux RAID <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] kernfs: handle poll correctly on 'direct_read' files.
Date: Mon, 16 Mar 2015 12:30:14 -0400 [thread overview]
Message-ID: <20150316163014.GA8353@htj.duckdns.org> (raw)
In-Reply-To: <20150316104452.366bffc0@notabene.brown>
On Mon, Mar 16, 2015 at 10:44:52AM +1100, NeilBrown wrote:
>
>
> Kernfs supports two styles of read: direct_read and seqfile_read.
>
> The latter supports 'poll' correctly thanks to the update of
> '->event' in kernfs_seq_show.
> The former does not as '->event' is never updated on a read.
>
> So add an appropriate update in kernfs_file_direct_read().
>
> This was noticed because some 'md' sysfs attributes were
> recently changed to use direct reads.
>
> Reported-by: Prakash Punnoor <prakash@punnoor.de>
> Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
> Fixes: 750f199ee8b578062341e6ddfe36c59ac8ff2dcb
This fixes tag is kinda weird without further explanation.
> Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2015-03-16 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 23:44 [PATCH] kernfs: handle poll correctly on 'direct_read' files NeilBrown
2015-03-16 16:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316163014.GA8353@htj.duckdns.org \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=prakash@punnoor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).