From: Mike Snitzer <snitzer@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Alasdair Kergon <agk@redhat.com>, Neil Brown <neilb@suse.de>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: dm log userspace: use mempool_create_kmalloc_pool()
Date: Wed, 18 Mar 2015 18:30:46 -0400 [thread overview]
Message-ID: <20150318223045.GA17765@redhat.com> (raw)
In-Reply-To: <20150311125852.GA28768@redhat.com>
On Wed, Mar 11 2015 at 8:58am -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> On Sat, Mar 07 2015 at 7:43pm -0500,
> David Rientjes <rientjes@google.com> wrote:
>
> > Mempools created for kmalloc caches should use
> > mempool_create_kmalloc_pool().
> >
> > Cc: Alasdair Kergon <agk@redhat.com>
> > Cc: Mike Snitzer <snitzer@redhat.com>
> > Cc: Neil Brown <neilb@suse.de>
> > Signed-off-by: David Rientjes <rientjes@google.com>
>
> Thanks David, I'll get this queued up.
Turns out I already fixed this a different way about a month ago and
staged it for 4.1, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=db57216e710ea5c517f1030fafe7eb21ac938dc5
You'll be interested to note this portion of that commit's header:
"This _should_ eliminate DM's need for io_schedule_timeout() in
mempool_alloc(); so io_schedule() should be sufficient now."
I'll defer to you on whether you'd like to pursue switching to
io_schedule() in mempool_alloc().
prev parent reply other threads:[~2015-03-18 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 0:43 [patch] dm log userspace: use mempool_create_kmalloc_pool() David Rientjes
2015-03-11 12:58 ` Mike Snitzer
2015-03-18 22:30 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318223045.GA17765@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).