* Re: [neilb@suse.de: Re: MD request counter broken on 4.0-rc5 RAID1]
[not found] <20150325173346.GF8519@hostway.ca>
@ 2015-04-01 7:39 ` Gu Zheng
2015-04-01 11:07 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Gu Zheng @ 2015-04-01 7:39 UTC (permalink / raw)
To: neilb; +Cc: Simon Kirby, linux-raid
Hi Neil,
One question about md io stats account:
I find that we just accounting disk_stats.sectors[rw] and disk_stats.ios[rw] at
md_make_request, but I did not find accounting disk_stats.ticks[rw], do not we
need it? or I missed something?
Regards,
Gu
On 03/26/2015 01:33 AM, Simon Kirby wrote:
> Hello!
>
> Please note the following.
>
> Thanks,
>
> Simon-
>
> ----- Forwarded message from NeilBrown <neilb@suse.de> -----
>
> Date: Wed, 25 Mar 2015 11:46:18 +1100
> From: NeilBrown <neilb@suse.de>
> To: Simon Kirby <sim@hostway.ca>
> Cc: linux-raid@vger.kernel.org
> Subject: Re: MD request counter broken on 4.0-rc5 RAID1
> X-Mailer: Claws Mail 3.10.1-162-g4d0ed6 (GTK+ 2.24.25; x86_64-suse-linux-gnu)
>
> On Tue, 24 Mar 2015 17:04:03 -0700 Simon Kirby <sim@hostway.ca> wrote:
>
>> Hello :)
>>
>> I'm seeing "iostat -x -k 1" print this after a RAID1 rebuild on 4.0-rc5.
>> It's not abnormal other than it's 3-disk, with one being SSD (sdc) and
>> the other two being write-mostly:
>>
>> Device: rrqm/s wrqm/s r/s w/s rkB/s wkB/s avgrq-sz avgqu-sz await r_await w_await svctm %util
>> sda 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
>> sdb 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
>> sdc 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
>> md0 0.00 0.00 0.00 0.00 0.00 0.00 0.00 345.00 0.00 0.00 0.00 0.00 100.00
>> md2 0.00 0.00 0.00 0.00 0.00 0.00 0.00 58779.00 0.00 0.00 0.00 0.00 100.00
>> md1 0.00 0.00 0.00 0.00 0.00 0.00 0.00 12.00 0.00 0.00 0.00 0.00 100.00
>>
>> This was working on 3.18. Shall I bisect, or is it obvious?
>
> Almost certainly 18c0b223cf9901727ef3b02da6711ac930b4e5d4 in 3.19.
>
> It adds 'part_inc_in_flight' and never decrements it.
>
> Complain to the author.
>
> Thanks,
> NeilBrown
>
>>
>> It seems to just be leaking as the counters were going up gradually while
>> it was rebuilding.
>>
>> Personalities : [linear] [raid0] [raid1] [raid10]
>> md1 : active raid1 sdb2[1](W) sda2[0](W) sdc2[2]
>> 530048 blocks [3/3] [UUU]
>>
>> md2 : active raid1 sdb3[0](W) sdc3[2] sda3[1](W)
>> 153613440 blocks [3/3] [UUU]
>>
>> md0 : active raid1 sdb1[0](W) sdc1[2] sda1[1](W)
>> 2104384 blocks [3/3] [UUU]
>>
>> unused devices: <none>
>>
>> Simo-
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> ----- End forwarded message -----
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [neilb@suse.de: Re: MD request counter broken on 4.0-rc5 RAID1]
2015-04-01 7:39 ` [neilb@suse.de: Re: MD request counter broken on 4.0-rc5 RAID1] Gu Zheng
@ 2015-04-01 11:07 ` NeilBrown
2015-04-02 19:54 ` Simon Kirby
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2015-04-01 11:07 UTC (permalink / raw)
To: Gu Zheng; +Cc: Simon Kirby, linux-raid
[-- Attachment #1: Type: text/plain, Size: 3298 bytes --]
On Wed, 1 Apr 2015 15:39:47 +0800 Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
> Hi Neil,
> One question about md io stats account:
> I find that we just accounting disk_stats.sectors[rw] and disk_stats.ios[rw] at
> md_make_request, but I did not find accounting disk_stats.ticks[rw], do not we
> need it? or I missed something?
No, I don't think you are missing anything. md doesn't track 'ticks' - and
no-one has ever complained.
NeilBrown
>
> Regards,
> Gu
>
> On 03/26/2015 01:33 AM, Simon Kirby wrote:
>
> > Hello!
> >
> > Please note the following.
> >
> > Thanks,
> >
> > Simon-
> >
> > ----- Forwarded message from NeilBrown <neilb@suse.de> -----
> >
> > Date: Wed, 25 Mar 2015 11:46:18 +1100
> > From: NeilBrown <neilb@suse.de>
> > To: Simon Kirby <sim@hostway.ca>
> > Cc: linux-raid@vger.kernel.org
> > Subject: Re: MD request counter broken on 4.0-rc5 RAID1
> > X-Mailer: Claws Mail 3.10.1-162-g4d0ed6 (GTK+ 2.24.25; x86_64-suse-linux-gnu)
> >
> > On Tue, 24 Mar 2015 17:04:03 -0700 Simon Kirby <sim@hostway.ca> wrote:
> >
> >> Hello :)
> >>
> >> I'm seeing "iostat -x -k 1" print this after a RAID1 rebuild on 4.0-rc5.
> >> It's not abnormal other than it's 3-disk, with one being SSD (sdc) and
> >> the other two being write-mostly:
> >>
> >> Device: rrqm/s wrqm/s r/s w/s rkB/s wkB/s avgrq-sz avgqu-sz await r_await w_await svctm %util
> >> sda 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
> >> sdb 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
> >> sdc 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00
> >> md0 0.00 0.00 0.00 0.00 0.00 0.00 0.00 345.00 0.00 0.00 0.00 0.00 100.00
> >> md2 0.00 0.00 0.00 0.00 0.00 0.00 0.00 58779.00 0.00 0.00 0.00 0.00 100.00
> >> md1 0.00 0.00 0.00 0.00 0.00 0.00 0.00 12.00 0.00 0.00 0.00 0.00 100.00
> >>
> >> This was working on 3.18. Shall I bisect, or is it obvious?
> >
> > Almost certainly 18c0b223cf9901727ef3b02da6711ac930b4e5d4 in 3.19.
> >
> > It adds 'part_inc_in_flight' and never decrements it.
> >
> > Complain to the author.
> >
> > Thanks,
> > NeilBrown
> >
> >>
> >> It seems to just be leaking as the counters were going up gradually while
> >> it was rebuilding.
> >>
> >> Personalities : [linear] [raid0] [raid1] [raid10]
> >> md1 : active raid1 sdb2[1](W) sda2[0](W) sdc2[2]
> >> 530048 blocks [3/3] [UUU]
> >>
> >> md2 : active raid1 sdb3[0](W) sdc3[2] sda3[1](W)
> >> 153613440 blocks [3/3] [UUU]
> >>
> >> md0 : active raid1 sdb1[0](W) sdc1[2] sda1[1](W)
> >> 2104384 blocks [3/3] [UUU]
> >>
> >> unused devices: <none>
> >>
> >> Simo-
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > ----- End forwarded message -----
> > .
> >
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [neilb@suse.de: Re: MD request counter broken on 4.0-rc5 RAID1]
2015-04-01 11:07 ` NeilBrown
@ 2015-04-02 19:54 ` Simon Kirby
0 siblings, 0 replies; 3+ messages in thread
From: Simon Kirby @ 2015-04-02 19:54 UTC (permalink / raw)
To: NeilBrown; +Cc: Gu Zheng, linux-raid
On Wed, Apr 01, 2015 at 10:07:25PM +1100, NeilBrown wrote:
> On Wed, 1 Apr 2015 15:39:47 +0800 Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
>
> > Hi Neil,
> > One question about md io stats account:
> > I find that we just accounting disk_stats.sectors[rw] and disk_stats.ios[rw] at
> > md_make_request, but I did not find accounting disk_stats.ticks[rw], do not we
> > need it? or I missed something?
>
> No, I don't think you are missing anything. md doesn't track 'ticks' - and
> no-one has ever complained.
Hmm, yes, I guess "working" before was "0% utilization". :)
Simon-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-02 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150325173346.GF8519@hostway.ca>
2015-04-01 7:39 ` [neilb@suse.de: Re: MD request counter broken on 4.0-rc5 RAID1] Gu Zheng
2015-04-01 11:07 ` NeilBrown
2015-04-02 19:54 ` Simon Kirby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).