From: Christoph Hellwig <hch@lst.de>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
Azat Khuzhin <a3at.mail@gmail.com>,
"Kernel.org-Linux-RAID" <linux-raid@vger.kernel.org>,
Guoqing Jiang <GQJiang@suse.com>, Tejun Heo <tj@kernel.org>,
Jan Kara <jack@suse.cz>, Jens Axboe <axboe@fb.com>,
dm-devel@redhat.com
Subject: Re: Bisected, with rfc/patch - was Re: BUG: unable to handle kernel NULL pointer dereference at sysfs_do_create_link_sd (after mdadm)
Date: Fri, 24 Apr 2015 10:27:09 +0200 [thread overview]
Message-ID: <20150424082709.GA19218@lst.de> (raw)
In-Reply-To: <20150424120932.3d554638@notabene.brown>
On Fri, Apr 24, 2015 at 12:09:32PM +1000, NeilBrown wrote:
> I'm pretty sure that the md code is already as close to the "dm model" as it
> meaningfully can be.
>
> If I move bdi_destroy out of blk_release_queue (which really think is too
> later) and place it in blk_cleanup_queue (which seems a credible place for
> it), and then move the blk_cleanup_queue call in md_free up before the
> del_gendisk() call (which is probably the right thing to do anyway, though dm
> has the same order that md currently has) then I don't get any crashes and
> I'm almost convince it is correct...
This looks reasonable to me, thanks.
next prev parent reply other threads:[~2015-04-24 8:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 17:15 BUG: unable to handle kernel NULL pointer dereference at sysfs_do_create_link_sd (after mdadm) Azat Khuzhin
2015-04-15 2:44 ` Guoqing Jiang
2015-04-15 8:47 ` Azat Khuzhin
2015-04-23 6:05 ` Bisected, with rfc/patch - was " NeilBrown
2015-04-23 7:37 ` Christoph Hellwig
2015-04-23 8:03 ` NeilBrown
2015-04-23 16:10 ` Christoph Hellwig
2015-04-24 2:09 ` NeilBrown
2015-04-24 8:27 ` Christoph Hellwig [this message]
2015-04-27 4:12 ` [PATCH -stable] block: destroy bdi before blockdev is unregistered NeilBrown
2015-04-27 13:03 ` Christoph Hellwig
2015-04-27 16:27 ` Jens Axboe
2015-04-28 16:41 ` Mike Snitzer
2015-04-28 21:25 ` NeilBrown
2015-04-29 13:35 ` Christoph Hellwig
2015-04-29 16:02 ` Peter Zijlstra
2015-04-30 0:06 ` NeilBrown
2015-04-30 0:32 ` [PATCH stable] block: discard bdi_unregister() in favour of bdi_destroy() NeilBrown
2015-04-30 8:35 ` Peter Zijlstra
2015-05-06 16:11 ` [dm-devel] " Dan Williams
2015-05-08 5:09 ` [PATCH v2] " NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424082709.GA19218@lst.de \
--to=hch@lst.de \
--cc=GQJiang@suse.com \
--cc=a3at.mail@gmail.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).