From: Christoph Hellwig <hch@lst.de>
To: NeilBrown <neilb@suse.de>
Cc: Ming Lin <mlin@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Kent Overstreet <kent.overstreet@gmail.com>,
Jens Axboe <axboe@kernel.dk>, Dongsu Park <dpark@posteo.net>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev()
Date: Mon, 25 May 2015 16:17:08 +0200 [thread overview]
Message-ID: <20150525141708.GA26249@lst.de> (raw)
In-Reply-To: <20150525175414.6a1fc33d@notabene.brown>
On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
> Did I write that? I guess I did :-(
> I meant *after*. Don't get rid of bio_fits_rdev until split_bio is in
> chunk_aligned_read().
I suspect the whole series could use some reordering.
patch 1:
add ->bio_split and blk_queue_split
patch 2..n:
one for each non-trivial driver that implements ->merge_bvec_fn to
remove it and instead split bios in ->make_request. The md patch
to do the right thing in chunk_aligned_read goes into the general
md patch here. The bcache patch also goes into this series.
patch n+1:
- add blk_queue_split calls for remaining trivial drivers
patch n+2:
- remove ->merge_bvec_fn and checking of max_sectors a for all
drivers, simplify bio_add_page
patch n+2:
- remove splitting in blkdev_issue_discard
patch n+3
- remove bio_fits_rdev
patch n+4
- remove bio_get_nr_vecs
patch n+4
- use bio_add_page
patch n+5
- update documentation
next prev parent reply other threads:[~2015-05-25 14:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1432318723-18829-1-git-send-email-mlin@kernel.org>
2015-05-22 18:18 ` [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-25 5:48 ` NeilBrown
2015-05-25 7:03 ` Ming Lin
2015-05-25 7:54 ` NeilBrown
2015-05-25 14:17 ` Christoph Hellwig [this message]
2015-05-26 14:33 ` Ming Lin
2015-05-26 22:32 ` Ming Lin
2015-05-26 23:03 ` NeilBrown
2015-05-26 23:42 ` Ming Lin
2015-05-27 0:38 ` NeilBrown
2015-05-27 8:15 ` Christoph Hellwig
2015-05-22 18:18 ` [PATCH v4 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-22 18:18 ` [PATCH v4 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-25 5:49 ` NeilBrown
2015-05-25 14:04 ` Christoph Hellwig
2015-05-25 15:02 ` Ilya Dryomov
2015-05-25 15:08 ` Christoph Hellwig
2015-05-25 15:19 ` Ilya Dryomov
2015-05-25 15:35 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525141708.GA26249@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dpark@posteo.net \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).