From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev() Date: Mon, 25 May 2015 16:17:08 +0200 Message-ID: <20150525141708.GA26249@lst.de> References: <1432318723-18829-1-git-send-email-mlin@kernel.org> <1432318723-18829-7-git-send-email-mlin@kernel.org> <20150525154829.4330f149@notabene.brown> <20150525175414.6a1fc33d@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150525175414.6a1fc33d@notabene.brown> Sender: linux-raid-owner@vger.kernel.org To: NeilBrown Cc: Ming Lin , lkml , Christoph Hellwig , Kent Overstreet , Jens Axboe , Dongsu Park , linux-raid@vger.kernel.org List-Id: linux-raid.ids On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote: > Did I write that? I guess I did :-( > I meant *after*. Don't get rid of bio_fits_rdev until split_bio is in > chunk_aligned_read(). I suspect the whole series could use some reordering. patch 1: add ->bio_split and blk_queue_split patch 2..n: one for each non-trivial driver that implements ->merge_bvec_fn to remove it and instead split bios in ->make_request. The md patch to do the right thing in chunk_aligned_read goes into the general md patch here. The bcache patch also goes into this series. patch n+1: - add blk_queue_split calls for remaining trivial drivers patch n+2: - remove ->merge_bvec_fn and checking of max_sectors a for all drivers, simplify bio_add_page patch n+2: - remove splitting in blkdev_issue_discard patch n+3 - remove bio_fits_rdev patch n+4 - remove bio_get_nr_vecs patch n+4 - use bio_add_page patch n+5 - update documentation