From: Neil Brown <neilb@suse.de>
To: Firo Yang <firogm@gmail.com>
Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] md: fix a build warning
Date: Mon, 15 Jun 2015 15:58:46 +1000 [thread overview]
Message-ID: <20150615155846.7b85f2cd@home.neil.brown.name> (raw)
In-Reply-To: <1433986870-7014-1-git-send-email-firogm@gmail.com>
On Thu, 11 Jun 2015 09:41:10 +0800
Firo Yang <firogm@gmail.com> wrote:
> Warning like this:
>
> drivers/md/md.c: In function ‘update_array_info’:
> drivers/md/md.c:6394:26: warning: logical not is only applied
> to the left hand side of comparison [-Wlogical-not-parentheses]
> !mddev->persistent != info->not_persistent||
>
> Fix it as Neil Brown said:
> mddev->persistent != !info->not_persistent ||
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index dd85be9..a3528b9 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6391,7 +6391,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
> mddev->ctime != info->ctime ||
> mddev->level != info->level ||
> /* mddev->layout != info->layout || */
> - !mddev->persistent != info->not_persistent||
> + mddev->persistent != !info->not_persistent ||
> mddev->chunk_sectors != info->chunk_size >> 9 ||
> /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */
> ((state^info->state) & 0xfffffe00)
applied, thanks.
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-06-15 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 1:41 [PATCH v2] md: fix a build warning Firo Yang
2015-06-15 5:58 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615155846.7b85f2cd@home.neil.brown.name \
--to=neilb@suse.de \
--cc=firogm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).