From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-raid@vger.kernel.org, Kernel-team@fb.com,
songliubraving@fb.com, hch@infradead.org,
dan.j.williams@intel.com, neilb@suse.de
Subject: Re: [PATCH 1/9] MD: add a new disk role to present cache device
Date: Tue, 4 Aug 2015 07:28:24 -0700 [thread overview]
Message-ID: <20150804142824.GA8204@infradead.org> (raw)
In-Reply-To: <e871cc4fc266c76f1d4b55225f2c0a6aacb18680.1438215986.git.shli@fb.com>
> case 0xfffe: /* faulty */
> set_bit(Faulty, &rdev->flags);
> break;
> + case 0xfffd: /* cache device */
Any chance to get constants for these magic numbers as an additional
prep patch?
Also I don't really think that adding the role without the actual
implementation is that useful.
next prev parent reply other threads:[~2015-08-04 14:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:38 [PATCH 0/9]raid5: fix write hole Shaohua Li
2015-07-30 0:38 ` [PATCH 1/9] MD: add a new disk role to present cache device Shaohua Li
2015-08-04 14:28 ` Christoph Hellwig [this message]
2015-08-04 18:17 ` Song Liu
2015-08-05 0:25 ` NeilBrown
2015-08-05 1:05 ` NeilBrown
2015-07-30 0:38 ` [PATCH 2/9] md: override md superblock recovery_offset for " Shaohua Li
2015-08-04 14:30 ` Christoph Hellwig
2015-08-05 1:08 ` NeilBrown
2015-07-30 0:38 ` [PATCH 3/9] raid5: add basic stripe log Shaohua Li
2015-08-05 3:07 ` NeilBrown
2015-08-05 21:19 ` Shaohua Li
2015-08-12 3:20 ` NeilBrown
2015-07-30 0:38 ` [PATCH 4/9] raid5: log reclaim support Shaohua Li
2015-08-05 3:43 ` NeilBrown
2015-08-05 21:34 ` Shaohua Li
2015-08-12 3:50 ` NeilBrown
2015-08-05 3:52 ` NeilBrown
2015-07-30 0:38 ` [PATCH 5/9] raid5: log recovery Shaohua Li
2015-08-05 4:05 ` NeilBrown
2015-08-05 21:39 ` Shaohua Li
2015-08-12 3:51 ` NeilBrown
2015-07-30 0:38 ` [PATCH 6/9] raid5: disable batch with log enabled Shaohua Li
2015-07-30 0:38 ` [PATCH 7/9] raid5: don't allow resize/reshape with cache(log) support Shaohua Li
2015-08-05 4:13 ` NeilBrown
2015-08-05 21:42 ` Shaohua Li
2015-08-12 3:57 ` NeilBrown
2015-07-30 0:38 ` [PATCH 8/9] raid5: enable log for raid array with cache disk Shaohua Li
2015-07-30 0:38 ` [PATCH 9/9] raid5: skip resync if cache(log) is enabled Shaohua Li
2015-08-05 4:16 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804142824.GA8204@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).