From: NeilBrown <neilb@suse.com>
To: Shaohua Li <shli@fb.com>
Cc: linux-raid@vger.kernel.org, Kernel-team@fb.com,
songliubraving@fb.com, hch@infradead.org,
dan.j.williams@intel.com
Subject: Re: [PATCH 4/9] raid5: log reclaim support
Date: Wed, 5 Aug 2015 13:52:43 +1000 [thread overview]
Message-ID: <20150805135243.430fead5@noble> (raw)
In-Reply-To: <41a6d2e74494506fcd6ffd68a5884d38dc0bfa8e.1438215986.git.shli@fb.com>
On Wed, 29 Jul 2015 17:38:44 -0700 Shaohua Li <shli@fb.com> wrote:
> + while (!list_empty(&log->stripe_end_ios)) {
> + io = list_first_entry(&log->stripe_end_ios,
> + struct r5l_io_unit, log_sibling);
> + list_move_tail(&io->log_sibling, &list);
> + free += (io->log_end - io->log_start +
> + log->total_blocks) % log->total_blocks;
> + }
sorry, forgot to mention this bit.
That '%' is acting on 64 but numbers, so it won't build in a 32bit
machine.
Maybe use SECTOR_DIV, maybe do an
if (x > y) free = x-y else free = x+total-y;
or something.
NeilBrown
next prev parent reply other threads:[~2015-08-05 3:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:38 [PATCH 0/9]raid5: fix write hole Shaohua Li
2015-07-30 0:38 ` [PATCH 1/9] MD: add a new disk role to present cache device Shaohua Li
2015-08-04 14:28 ` Christoph Hellwig
2015-08-04 18:17 ` Song Liu
2015-08-05 0:25 ` NeilBrown
2015-08-05 1:05 ` NeilBrown
2015-07-30 0:38 ` [PATCH 2/9] md: override md superblock recovery_offset for " Shaohua Li
2015-08-04 14:30 ` Christoph Hellwig
2015-08-05 1:08 ` NeilBrown
2015-07-30 0:38 ` [PATCH 3/9] raid5: add basic stripe log Shaohua Li
2015-08-05 3:07 ` NeilBrown
2015-08-05 21:19 ` Shaohua Li
2015-08-12 3:20 ` NeilBrown
2015-07-30 0:38 ` [PATCH 4/9] raid5: log reclaim support Shaohua Li
2015-08-05 3:43 ` NeilBrown
2015-08-05 21:34 ` Shaohua Li
2015-08-12 3:50 ` NeilBrown
2015-08-05 3:52 ` NeilBrown [this message]
2015-07-30 0:38 ` [PATCH 5/9] raid5: log recovery Shaohua Li
2015-08-05 4:05 ` NeilBrown
2015-08-05 21:39 ` Shaohua Li
2015-08-12 3:51 ` NeilBrown
2015-07-30 0:38 ` [PATCH 6/9] raid5: disable batch with log enabled Shaohua Li
2015-07-30 0:38 ` [PATCH 7/9] raid5: don't allow resize/reshape with cache(log) support Shaohua Li
2015-08-05 4:13 ` NeilBrown
2015-08-05 21:42 ` Shaohua Li
2015-08-12 3:57 ` NeilBrown
2015-07-30 0:38 ` [PATCH 8/9] raid5: enable log for raid array with cache disk Shaohua Li
2015-07-30 0:38 ` [PATCH 9/9] raid5: skip resync if cache(log) is enabled Shaohua Li
2015-08-05 4:16 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805135243.430fead5@noble \
--to=neilb@suse.com \
--cc=Kernel-team@fb.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).