From: Christoph Hellwig <hch@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-raid@vger.kernel.org, shli@fb.com,
dan.j.williams@intel.com, neilb@suse.de, hch@infradead.org
Subject: Re: [PATCH 2/6] Show device as journal in --detail --examine
Date: Tue, 1 Sep 2015 23:53:03 -0700 [thread overview]
Message-ID: <20150902065303.GA20708@infradead.org> (raw)
In-Reply-To: <1440804426-1461372-3-git-send-email-songliubraving@fb.com>
> #define MD_FEATURE_NEW_OFFSET 64 /* new_offset must be honoured */
> +#define MD_FEATURE_JOURNAL 512 /* support write journal */
The kernel patches are using 256 here, so your userspace won't work
with them but rather generate very unhelpful warnings:
[ 16.177710] md: sdc does not have a valid v1.2 superblock, not importing!
[ 16.178634] md: md_import_device returned -22
mdadm: ADD_NEW_DISK for /dev/sdc failed: Invalid argument
next prev parent reply other threads:[~2015-09-02 6:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 23:27 [PATCH 0/6] mdadm support for journal device of RAID-4/5/6 Song Liu
2015-08-28 23:27 ` [PATCH 1/6] add macros for MD_DISK_ROLE_(SPARE/FAULTY) Song Liu
2015-08-28 23:27 ` [PATCH 2/6] Show device as journal in --detail --examine Song Liu
2015-09-02 6:53 ` Christoph Hellwig [this message]
2015-09-02 7:04 ` Song Liu
2015-09-02 7:07 ` Christoph Hellwig
2015-09-02 7:09 ` Song Liu
2015-08-28 23:27 ` [PATCH 3/6] Enable create array with write journal (--write-journal DEVICE) Song Liu
2015-10-06 18:32 ` Dan Williams
2015-10-07 6:06 ` Song Liu
2015-10-19 2:42 ` Neil Brown
2015-08-28 23:27 ` [PATCH 4/6] Assemble array with write journal Song Liu
2015-10-06 20:11 ` Dan Williams
2015-10-07 6:13 ` Song Liu
2015-08-28 23:27 ` [PATCH 5/6] Check write journal in incremental Song Liu
2015-10-06 20:17 ` Dan Williams
2015-10-19 2:32 ` Neil Brown
2015-08-28 23:27 ` [PATCH 6/6] Add help message and man entry for --write-journal Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902065303.GA20708@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).