linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dm: ioctl: prevent double freeing
@ 2015-09-04 11:22 Sudip Mukherjee
  2015-09-15  7:53 ` Sudip Mukherjee
  2015-09-15 16:18 ` [dm-devel] " Darrick J. Wong
  0 siblings, 2 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2015-09-04 11:22 UTC (permalink / raw)
  To: Alasdair Kergon, Mike Snitzer, dm-devel, Neil Brown
  Cc: linux-kernel, linux-raid, Sudip Mukherjee

DM_PARAMS_KMALLOC and DM_PARAMS_VMALLOC should never be set together in
param_flags. We are setting these flags while allocating so we know that
there is almost no chance of having these two set together but still we
can have some additional safety.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/md/dm-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 80a4395..aaad74e 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1680,7 +1680,7 @@ static void free_params(struct dm_ioctl *param, size_t param_size, int param_fla
 
 	if (param_flags & DM_PARAMS_KMALLOC)
 		kfree(param);
-	if (param_flags & DM_PARAMS_VMALLOC)
+	else if (param_flags & DM_PARAMS_VMALLOC)
 		vfree(param);
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-15 18:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-04 11:22 [PATCH] dm: ioctl: prevent double freeing Sudip Mukherjee
2015-09-15  7:53 ` Sudip Mukherjee
2015-09-15 16:18 ` [dm-devel] " Darrick J. Wong
2015-09-15 18:13   ` Mike Snitzer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).