30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

[Giedrius Statkevičius]

Hello,
I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in
/dev/sda2. After booting on linux-next and just after entering my password
cryptsetup segfaults and a stack trace is printed from the kernel. Since writing
down all those numbers is hard I've made a picture where it is shown:
https://i.imgur.com/6PHNUdv.jpg

I figured it had something to do with changes to memory management and thus find
out that commit 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke my system.
Reverting it there is no such error anymore and system boots fine past that
point. 

Could someone look into this? Thanks, Giedrius

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

[Geliang Tang]

On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote:
> Hello,
> I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in
> /dev/sda2. After booting on linux-next and just after entering my password
> cryptsetup segfaults and a stack trace is printed from the kernel. Since writing
> down all those numbers is hard I've made a picture where it is shown:
> https://i.imgur.com/6PHNUdv.jpg
> 
> I figured it had something to do with changes to memory management and thus find
> out that commit 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke my system.
> Reverting it there is no such error anymore and system boots fine past that
> point. 
> 
> Could someone look into this? Thanks, Giedrius

Bugfix for this has been sended out.
https://lkml.org/lkml/2015/10/8/342.

Thanks.

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

[Giedrius Statkevičius]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Thu, 8 Oct 2015, Geliang Tang wrote:

> On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote:
> > Hello,
> > I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in
> > /dev/sda2. After booting on linux-next and just after entering my password
> > cryptsetup segfaults and a stack trace is printed from the kernel. Since writing
> > down all those numbers is hard I've made a picture where it is shown:
> > https://i.imgur.com/6PHNUdv.jpg
> > 
> > I figured it had something to do with changes to memory management and thus find
> > out that commit 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke my system.
> > Reverting it there is no such error anymore and system boots fine past that
> > point. 
> > 
> > Could someone look into this? Thanks, Giedrius
> 
> Bugfix for this has been sended out.
> https://lkml.org/lkml/2015/10/8/342.
> 
> Thanks.
I've tested and that fixed this issue for me. I would've replied on that thread
but I can't find its Message-Id. Anyway, you can add:
Tested-By: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>

Thanks,
Giedrius

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

[Mike Snitzer]

On Sat, Oct 10 2015 at  8:44P -0400,
Giedrius Statkevičius <giedrius.statkevicius@gmail.com> wrote:

> On Thu, 8 Oct 2015, Geliang Tang wrote:
> 
> > On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote:
> > > Hello,
> > > I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in
> > > /dev/sda2. After booting on linux-next and just after entering my password
> > > cryptsetup segfaults and a stack trace is printed from the kernel. Since writing
> > > down all those numbers is hard I've made a picture where it is shown:
> > > https://i.imgur.com/6PHNUdv.jpg
> > > 
> > > I figured it had something to do with changes to memory management and thus find
> > > out that commit 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke my system.
> > > Reverting it there is no such error anymore and system boots fine past that
> > > point. 
> > > 
> > > Could someone look into this? Thanks, Giedrius
> > 
> > Bugfix for this has been sended out.
> > https://lkml.org/lkml/2015/10/8/342.
> > 
> > Thanks.
> I've tested and that fixed this issue for me. I would've replied on that thread
> but I can't find its Message-Id. Anyway, you can add:
> Tested-By: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>

I dropped the original commit because I'm really not seeing the value of
using kvfree (but it was motivated by reports of crashes from ktest,
etc).  I don't have any intention of picking it back up at this point
(so Geliang's fix will go unused at this point).

Mike