From: Vinod Koul <vinod.koul@intel.com>
To: NeilBrown <neilb@suse.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Stanislav Samsonov <slava@annapurnalabs.com>,
linux-raid <linux-raid@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH] async_tx: use GFP_NOWAIT rather than GFP_IO
Date: Thu, 7 Jan 2016 11:09:11 +0530 [thread overview]
Message-ID: <20160107053911.GH11778@localhost> (raw)
In-Reply-To: <87k2nm9rz9.fsf@notabene.neil.brown.name>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Thu, Jan 07, 2016 at 11:02:34AM +1100, NeilBrown wrote:
>
> These async_XX functions are called from md/raid5 in an atomic
> section, between get_cpu() and put_cpu(), so they must not sleep.
> So use GFP_NOWAIT rather than GFP_IO.
>
> Dan Williams writes: Longer term async_tx needs to be merged into md
> directly as we can allocate this unmap data statically per-stripe
> rather than per request.
>
> Fixed: 7476bd79fc01 ("async_pq: convert to dmaengine_unmap_data")
> Cc: stable@vger.kernel.org (v3.13+)
> Reported-and-tested-by: Stanislav Samsonov <slava@annapurnalabs.com>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>
> Thanks for taking this Vinod.
> It is currently in linux-next from my md tree, but I've just de-staged
> it so the next linux-next won't have it from me.
Okay this is not in dmaengine. But since we all agreed, I have picked and
will send to Linus later today. If anyone has any objections please speak up
Thanks
--
~Vinod
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-07 5:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 11:58 raid5 async_xor: sleep in atomic Stanislav Samsonov
2015-12-23 2:34 ` NeilBrown
2015-12-23 17:35 ` Dan Williams
2015-12-23 22:39 ` NeilBrown
2015-12-23 22:46 ` Dan Williams
2015-12-28 8:43 ` Stanislav Samsonov
2016-01-04 1:33 ` NeilBrown
2016-01-04 17:28 ` Dan Williams
2016-01-06 9:08 ` Vinod Koul
2016-01-07 0:02 ` [PATCH] async_tx: use GFP_NOWAIT rather than GFP_IO NeilBrown
2016-01-07 5:39 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107053911.GH11778@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=slava@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).