From: Shaohua Li <shli@kernel.org>
To: linux-raid <linux-raid@vger.kernel.org>
Cc: Brassow Jonathan <jbrassow@redhat.com>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
NeilBrown <neilb@suse.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
systemd-devel@freedesktop.org
Subject: Re: [PATCH 1/2] md: Inform udev about device removal when stopping
Date: Tue, 16 Feb 2016 12:05:53 -0800 [thread overview]
Message-ID: <20160216200553.GA13119@kernel.org> (raw)
In-Reply-To: <1455633877-4813-2-git-send-email-sebastian.riemer@profitbricks.com>
On Tue, Feb 16, 2016 at 03:44:36PM +0100, Sebastian Parschauer wrote:
> When stopping an MD device, then its device node /dev/mdX may still
> exist afterwards or it is recreated by udev. The next open() call
> can lead to creation of an inoperable MD device. The reason for
> this is that a change event (KOBJ_CHANGE) is announced to udev.
> So announce a removal event (KOBJ_REMOVE) to udev instead.
>
> A change is likely also required in mdadm because of the support
> for kernels prior to 2.6.28.
I didn't follow why we need the change. Shouldn't the KOBJ_REMOVE event be sent
automatically when gendisk is deleted?
mddev_put()->mddev_delayed_delete()->md_free()->del_gendisk().
Thanks,
Shaohua
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel
next prev parent reply other threads:[~2016-02-16 20:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 14:44 [PATCH 0/2] md/mdadm: Inform udev about device removal when stopping Sebastian Parschauer
2016-02-16 14:44 ` [PATCH 1/2] md: " Sebastian Parschauer
2016-02-16 20:05 ` Shaohua Li [this message]
2016-02-16 20:43 ` NeilBrown
2016-02-17 11:24 ` Sebastian Parschauer
2016-02-17 22:57 ` NeilBrown
2016-02-16 14:44 ` [PATCH 2/2] Manage: " Sebastian Parschauer
2016-02-16 17:41 ` Jes Sorensen
2016-02-16 18:03 ` Sebastian Parschauer
2016-02-16 18:40 ` Hannes Reinecke
2016-02-16 18:52 ` Jes Sorensen
2016-02-16 20:46 ` NeilBrown
2016-02-16 22:02 ` Jes Sorensen
2016-02-17 10:31 ` Sebastian Parschauer
2016-02-17 7:03 ` Hannes Reinecke
2016-02-17 13:06 ` Jes Sorensen
2016-02-17 13:16 ` Sebastian Parschauer
2016-02-17 17:33 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216200553.GA13119@kernel.org \
--to=shli@kernel.org \
--cc=Jes.Sorensen@redhat.com \
--cc=artur.paszkiewicz@intel.com \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=systemd-devel@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).