From: Shaohua Li <shli@kernel.org>
To: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Brassow Jonathan <jbrassow@redhat.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
NeilBrown <neilb@suse.com>, Hannes Reinecke <hare@suse.de>,
systemd-devel@freedesktop.org
Subject: Re: [PATCH] md: Drop sending a change uevent when stopping
Date: Wed, 17 Feb 2016 10:19:43 -0800 [thread overview]
Message-ID: <20160217181943.GA28011@kernel.org> (raw)
In-Reply-To: <1455726300-20340-1-git-send-email-sebastian.riemer@profitbricks.com>
On Wed, Feb 17, 2016 at 05:25:00PM +0100, Sebastian Parschauer wrote:
> When stopping an MD device, then its device node /dev/mdX may still
> exist afterwards or it is recreated by udev. The next open() call
> can lead to creation of an inoperable MD device. The reason for
> this is that a change event (KOBJ_CHANGE) is sent to udev which
> races against the remove event (KOBJ_REMOVE) from md_free().
> So drop sending the change event.
>
> A change is likely also required in mdadm as many versions send the
> change event to udev as well.
Makes sense, it's unlikely we need the CHANGE event. Applied.
Thanks,
Shaohua
next prev parent reply other threads:[~2016-02-17 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 16:25 [PATCH] md: Drop sending a change uevent when stopping Sebastian Parschauer
2016-02-17 18:19 ` Shaohua Li [this message]
2016-02-17 21:29 ` NeilBrown
2016-02-17 22:14 ` Shaohua Li
2016-02-18 6:45 ` Hannes Reinecke
2016-02-18 23:06 ` NeilBrown
2016-02-19 21:58 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217181943.GA28011@kernel.org \
--to=shli@kernel.org \
--cc=Jes.Sorensen@redhat.com \
--cc=artur.paszkiewicz@intel.com \
--cc=hare@suse.de \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=sebastian.riemer@profitbricks.com \
--cc=systemd-devel@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).