[PATCH] md:raid1: fix a dead loop when read from a WriteMostly disk

[PATCH] md:raid1: fix a dead loop when read from a WriteMostly disk

[Wei Fang]

If first_bad == this_sector when we get the WriteMostly disk
in read_balance(), valid disk will be returned with zero
max_sectors. It'll lead to a dead loop in make_request(), and
OOM will happen because of endless allocation of struct bio.

Since we can't get data from this disk in this case, so
continue for another disk.

Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
 drivers/md/raid1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 4e3843f..74d42c0 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -570,7 +570,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
 			if (best_dist_disk < 0) {
 				if (is_badblock(rdev, this_sector, sectors,
 						&first_bad, &bad_sectors)) {
-					if (first_bad < this_sector)
+					if (first_bad <= this_sector)
 						/* Cannot use this */
 						continue;
 					best_good_sectors = first_bad - this_sector;
-- 
1.7.1

Re: [PATCH] md:raid1: fix a dead loop when read from a WriteMostly disk

[Shaohua Li]

On Mon, Mar 21, 2016 at 07:18:32PM +0800, Wei Fang wrote:
> If first_bad == this_sector when we get the WriteMostly disk
> in read_balance(), valid disk will be returned with zero
> max_sectors. It'll lead to a dead loop in make_request(), and
> OOM will happen because of endless allocation of struct bio.
> 
> Since we can't get data from this disk in this case, so
> continue for another disk.

Good catch, applied.

Thanks,
Shaohua