linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Étienne Buira" <etienne.buira@gmail.com>
To: NeilBrown <mr@neil.brown.name>
Cc: linux-raid@vger.kernel.org
Subject: Re: Probable bug in md with rdev->new_data_offset
Date: Fri, 1 Apr 2016 08:15:16 +0200	[thread overview]
Message-ID: <20160401061515.GA24288@rcKGHUlyQfVFW> (raw)
In-Reply-To: <877fghrj2n.fsf@notabene.neil.brown.name>

On Fri, Apr 01, 2016 at 04:31:28PM +1100, NeilBrown wrote:
> On Tue, Mar 29 2016, Étienne Buira wrote:

../..

> 
> I guess sb->new_offset should be called sb->delta_offset.  If you look
> in md_p.h you will see:
> 
> 	__le32  new_offset;	/* signed number to add to data_offset in new
> 				 * layout.  0 == no-change.  This can be
> 				 * different on each device in the array.
> 				 */
> 
> which goes some way to explaining the situation.
> 
> NeilBrown

Hi Neil,

Thank you for the explanation, i have also looked at the sb loading
counterpart, and indeed, PAX did catch a false positive here.

For the record, the bug have been reported on Gentoo bugtracker [1].

[1] https://bugs.gentoo.org/show_bug.cgi?id=578502

Regards.

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2016-04-01  6:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 10:31 Probable bug in md with rdev->new_data_offset Étienne Buira
2016-03-28 12:19 ` Phil Turmel
2016-03-29 11:07   ` Étienne Buira
2016-04-01  5:31     ` NeilBrown
2016-04-01  6:15       ` Étienne Buira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401061515.GA24288@rcKGHUlyQfVFW \
    --to=etienne.buira@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mr@neil.brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).