From: Mike Snitzer <snitzer@redhat.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
Alasdair G Kergon <agk@redhat.com>, Jens Axboe <axboe@fb.com>,
dm-devel@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
david.s.gordon@intel.com, Tom Lendacky <thomas.lendacky@amd.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
smueller@chronox.de, tadeusz.struk@intel.com,
Masanari Iida <standby24x7@gmail.com>,
shli@kernel.org, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org,
Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework
Date: Mon, 18 Apr 2016 09:36:12 -0400 [thread overview]
Message-ID: <20160418133612.GA16853@redhat.com> (raw)
In-Reply-To: <CAMz4ku+hXbgx1+YcdJWbCBW7KoeFisk5qcquAAg0fD5Qw5XDFQ@mail.gmail.com>
On Mon, Apr 18 2016 at 1:31am -0400,
Baolin Wang <baolin.wang@linaro.org> wrote:
> Hi Herbert,
>
> On 15 April 2016 at 21:48, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > On Tue, Mar 15, 2016 at 03:47:58PM +0800, Baolin Wang wrote:
> >> Now some cipher hardware engines prefer to handle bulk block by merging requests
> >> to increase the block size and thus increase the hardware engine processing speed.
> >>
> >> This patchset introduces request bulk mode to help the crypto hardware drivers
> >> improve in efficiency.
> >
> > Could you please explain why this merging can't be done in dm-crypt
> > instead?
>
> We've tried to do this in dm-crypt, but it failed.
> The dm-crypt maintainer explained to me that I should optimize the
> driver, not add strange hw-dependent crypto modes to dm-crypt, this is
> not the first crypto accelerator that is just not suited for this kind
> of use.
As a DM mainatiner my only contribution to this line of discussion was
relative to your proposal to train the dm-crypt target (which is
bio-based) to also provide request-based support, see:
https://www.redhat.com/archives/dm-devel/2015-November/msg00112.html
But follow-up discussion occured, primarily with Milan Broz, which led
to this bulk mode support in the crypto layer. Pretty strange Milan
wasn't cc'd on your patchset posting (I've now cc'd him).
Mike
next prev parent reply other threads:[~2016-04-18 13:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 7:47 [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang
2016-03-15 7:47 ` [PATCH v2 1/4] scatterlist: Introduce some helper functions Baolin Wang
2016-04-02 15:00 ` Robert Jarzmik
2016-04-05 7:10 ` Baolin Wang
2016-04-20 7:34 ` Baolin Wang
2016-04-20 8:38 ` Herbert Xu
2016-03-15 7:48 ` [PATCH v2 2/4] crypto: Introduce some helper functions to help to merge requests Baolin Wang
2016-03-15 7:48 ` [PATCH v2 3/4] crypto: Introduce the bulk mode for crypto engine framework Baolin Wang
2016-03-15 7:48 ` [PATCH v2 4/4] md: dm-crypt: Initialize the sector number for one request Baolin Wang
2016-04-15 13:48 ` [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu
2016-04-18 5:31 ` Baolin Wang
2016-04-18 5:45 ` Herbert Xu
2016-04-18 6:02 ` Baolin Wang
2016-04-18 7:04 ` Herbert Xu
2016-04-18 7:21 ` Baolin Wang
2016-04-18 7:24 ` Herbert Xu
2016-04-18 7:58 ` Baolin Wang
2016-04-18 8:04 ` Herbert Xu
2016-04-18 8:14 ` Baolin Wang
2016-04-18 8:17 ` Herbert Xu
2016-04-18 8:28 ` Baolin Wang
2016-04-18 8:31 ` Herbert Xu
2016-04-18 8:40 ` Baolin Wang
2016-04-18 8:41 ` Herbert Xu
2016-04-18 8:51 ` Baolin Wang
2016-04-18 13:36 ` Mike Snitzer [this message]
2016-04-18 21:22 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418133612.GA16853@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=david.s.gordon@intel.com \
--cc=dm-devel@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=robert.jarzmik@free.fr \
--cc=shli@kernel.org \
--cc=smueller@chronox.de \
--cc=standby24x7@gmail.com \
--cc=tadeusz.struk@intel.com \
--cc=thomas.lendacky@amd.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).