From: Shaohua Li <shli@kernel.org>
To: "Michał Pecio" <michal.pecio@gmail.com>
Cc: Neil Brown <neilb@suse.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] md/raid0: remove empty line printk from dump_zones
Date: Mon, 25 Apr 2016 08:42:56 -0700 [thread overview]
Message-ID: <20160425154256.GA108964@kernel.org> (raw)
In-Reply-To: <20160424181145.41aae9dd@sauron>
On Sun, Apr 24, 2016 at 06:11:45PM +0200, Michał Pecio wrote:
>
> Remove the final printk. All preceding output is already properly
> newline-terminated and the printk isn't even KERN_CONT to begin with,
> so it only adds one empty line to the log.
>
> Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> ---
> drivers/md/raid0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index f8e5db0..3e51f4d 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -70,7 +70,6 @@ static void dump_zones(struct mddev *mddev)
> (unsigned long long)zone_size>>1);
> zone_start = conf->strip_zone[j].zone_end;
> }
> - printk(KERN_INFO "\n");
> }
applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-25 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 16:11 [PATCH] md/raid0: remove empty line printk from dump_zones Michał Pecio
2016-04-25 15:42 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425154256.GA108964@kernel.org \
--to=shli@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).