From: Shaohua Li <shli@kernel.org>
To: Joey Liao <joeyliao@qnap.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: Write to the degraded raid5 will trigger the call trace dump when skip_copy is enabled
Date: Fri, 29 Apr 2016 14:17:19 -0700 [thread overview]
Message-ID: <20160429211719.GA104659@kernel.org> (raw)
In-Reply-To: <CAHvN=inPP5ubYK1YkNW_B1b9ouhqBo8qMMfVcGSjddMYekDEng@mail.gmail.com>
On Fri, Apr 29, 2016 at 06:54:10PM +0800, Joey Liao wrote:
> Hi all,
>
> For improving the I/O performance, we try to enable the raid 5
> skip_copy feature by default. It indeed has some benefit, however, it
> will always (not a random issue) dump the following call trace
> repeatedly when we try to write the raid 5 block device. It is related
> to the following codes in handle_stripe_clean_event() in raid5.c.
>
> WARN_ON(test_bit(R5_SkipCopy, &dev->flags));
> WARN_ON(dev->page != dev->orig_page);
>
> Is it a known bug for skip_copy feature?
> Does it do harm to the data integrity?
> If we would like to prevent this call trace, for your suggestion how
> should we do to modify the source code?
Looks the two WARN_ON should be deleted. if the dev has R5_LOCKED, it's legit
the dev has SkipCopy set and page != orig_page. I'll delete the code. This will
not harm to data integrity.
Thanks,
Shaohua
next prev parent reply other threads:[~2016-04-29 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 10:54 Write to the degraded raid5 will trigger the call trace dump when skip_copy is enabled Joey Liao
2016-04-29 21:17 ` Shaohua Li [this message]
2016-05-02 14:45 ` Joey Liao
2016-05-04 3:21 ` Joey Liao
2016-05-08 22:23 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429211719.GA104659@kernel.org \
--to=shli@kernel.org \
--cc=joeyliao@qnap.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).