From: Shaohua Li <shli@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
Mike Lovell <mike.lovell@endurance.com>,
linux-raid@vger.kernel.org
Subject: Re: problems with lots of arrays
Date: Tue, 10 May 2016 17:45:50 -0700 [thread overview]
Message-ID: <20160511004550.GB127453@kernel.org> (raw)
In-Reply-To: <87wpn1sfk6.fsf@notabene.neil.brown.name>
On Wed, May 11, 2016 at 08:39:53AM +1000, NeilBrown wrote:
> On Wed, May 11 2016, Jes Sorensen wrote:
>
> > Mike Lovell <mike.lovell@endurance.com> writes:
> >> we have a number of systems that have a large number of software
> >> arrays running. its in the couple hundred range. we have been using a
> >> custom built kernel based on 3.4 but are wanting to update to a
> >> mainline kernel and have been experimenting with 4.4. the systems are
> >> running recent centos 6 releases but we have been downgrading the
> >> mdadm version from 3.3.2 in 6.7 to a custom build 3.2.6. we installed
> >> the downgraded version due to a problem with array numbering. i
> >> emailed the list a while ago explaining the issue and submitting a
> >> patch to fix [1]. i never heard anything back and since we had a
> >> simple fix i didn't follow up on it.
> >
> > [snip]
> >
> >> what do you all think?
> >>
> >> thanks
> >> mike
> >>
> >> [1] http://marc.info/?l=linux-raid&m=142387809409798&w=2
> >
> > Staying consistent in using dev_t rather than casting back and forth to
> > int seems a reasonable fix to apply to mdadm. It obviously won't change
> > the issues with the newer kernels, but I don't see any reason why we
> > shouldn't apply that fix to mdadm.
> >
> > Neil any thoughts on this?
>
> I agree that changing "int" to "dev_t" is a good idea.
>
> We should really fix the more general problem too.
>
> On any kernel with /sys/module/md_mod/parameters/new_array
> find_free_devnm avoid trying anything above 511. (1<<9)-1.
>
> If that fails to find a free number, then it should probably try a name
> like "md_NN" and act as though ci->name is set.
>
> Also, when a "name" given for the md array that is longer than 28 bytes
> we need to fall back to choose an array name ourselves even if ci->name
> is set. Start with md_512 and work upwards.
> Rather than probing we should read /sys/block looking for "md_*" and
> maybe choose 1 more than the largest number found.
I'm wondering why udev open the device with major/minor without checking if the
device exists. A simple 'stat' check is neat.
Thanks,
Shaohua
next prev parent reply other threads:[~2016-05-11 0:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 23:24 problems with lots of arrays Mike Lovell
2016-05-06 6:43 ` NeilBrown
2016-05-06 17:02 ` Mike Lovell
2016-05-06 17:59 ` Mike Lovell
2016-05-06 23:13 ` NeilBrown
2016-05-10 20:48 ` Jes Sorensen
2016-05-10 22:39 ` NeilBrown
2016-05-11 0:45 ` Shaohua Li [this message]
2016-05-12 1:55 ` NeilBrown
2016-05-12 5:58 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511004550.GB127453@kernel.org \
--to=shli@kernel.org \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=mike.lovell@endurance.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).