From: Shaohua Li <shli@kernel.org>
To: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] raid1/raid10: slow down resync if there is non-resync activity pending
Date: Mon, 13 Jun 2016 11:48:07 -0700 [thread overview]
Message-ID: <20160613184807.GB20136@kernel.org> (raw)
In-Reply-To: <1465825879-2059-1-git-send-email-tomasz.majchrzak@intel.com>
On Mon, Jun 13, 2016 at 03:51:19PM +0200, Tomasz Majchrzak wrote:
> A performance drop of mkfs has been observed on RAID10 during resync
> since commit 09314799e4f0 ("md: remove 'go_faster' option from
> ->sync_request()"). Resync sends so many IOs it slows down non-resync
> IOs significantly (few times). Add a short delay to a resync. The
> previous long sleep (1s) has proven unnecessary, even very short delay
> brings performance right.
>
> The change also applied to raid1. The problem has not been observed on
> raid1, however it shares barriers code with raid10 so it might be an
> issue for some setup too.
Applied, thanks!
prev parent reply other threads:[~2016-06-13 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 13:51 [PATCH] raid1/raid10: slow down resync if there is non-resync activity pending Tomasz Majchrzak
2016-06-13 18:48 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613184807.GB20136@kernel.org \
--to=shli@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=tomasz.majchrzak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).