From: Fam Zheng <famz@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
Keith Busch <keith.busch@intel.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Shaohua Li <shli@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
famz@redhat.com, Jiri Kosina <jikos@kernel.org>,
linux-block@vger.kernel.org, dan.j.williams@intel.com,
"Ed L. Cashin" <ed.cashin@acm.org>, Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Minchan Kim <minchan@kernel.org>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 00/12] gendisk: Generate uevent after attribute available
Date: Fri, 1 Jul 2016 09:01:13 +0800 [thread overview]
Message-ID: <20160701010113.GB10122@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160630063839.GA17205@infradead.org>
On Wed, 06/29 23:38, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016 at 02:35:54PM +0800, Fam Zheng wrote:
> > also more code and less flexible IMO. For example, we need at least two
> > variants, for attribute_group and device_attribute separately, right?
>
> Yes, or maybe just a calling convention that just passes both.
OK, I can look into that, but I'm not sure about the error handling. Currently
add_disk returns void, do you have any plan on that too? should I change it in
v3 (to at least return the attribute creation failure)?
Fam
next prev parent reply other threads:[~2016-07-01 1:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 1:59 [PATCH v2 00/12] gendisk: Generate uevent after attribute available Fam Zheng
2016-06-30 1:59 ` [PATCH v2 01/12] genhd: Add "gen_uevent" parameter to add_disk Fam Zheng
2016-06-30 1:59 ` [PATCH v2 02/12] genhd: Honor gen_uevent and add disk_gen_uevents Fam Zheng
2016-06-30 3:26 ` kbuild test robot
2016-06-30 1:59 ` [PATCH v2 03/12] virtio-blk: Generate uevent after attribute available Fam Zheng
2016-06-30 1:59 ` [PATCH v2 04/12] axonrom: " Fam Zheng
2016-06-30 22:10 ` Dan Williams
2016-07-01 1:03 ` Fam Zheng
2016-06-30 1:59 ` [PATCH v2 05/12] aoeblk: " Fam Zheng
2016-07-01 0:57 ` Ed Cashin
2016-06-30 1:59 ` [PATCH v2 06/12] mtip32xx: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 07/12] pktcdvd: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 08/12] zram: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 09/12] md: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 10/12] mmc: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 11/12] mtd: " Fam Zheng
2016-06-30 1:59 ` [PATCH v2 12/12] nvme: " Fam Zheng
2016-06-30 6:24 ` [PATCH v2 00/12] gendisk: " Christoph Hellwig
2016-06-30 6:35 ` Fam Zheng
2016-06-30 6:38 ` Christoph Hellwig
2016-07-01 1:01 ` Fam Zheng [this message]
2016-07-01 1:29 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701010113.GB10122@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=computersforpeace@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dwmw2@infradead.org \
--cc=ed.cashin@acm.org \
--cc=hch@infradead.org \
--cc=jikos@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=ngupta@vflare.org \
--cc=paulus@samba.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=shli@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).