From: Mike Snitzer <snitzer@redhat.com>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Alasdair Kergon <agk@redhat.com>, Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: dm: fix parameter to blk_delay_queue()
Date: Fri, 15 Jul 2016 09:59:05 -0400 [thread overview]
Message-ID: <20160715135905.GA22026@redhat.com> (raw)
In-Reply-To: <1468589228-20722-1-git-send-email-tahsin@google.com>
On Fri, Jul 15 2016 at 9:27am -0400,
Tahsin Erdogan <tahsin@google.com> wrote:
> Second parameter to blk_delay_queue() must be in msec units not jiffies.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
This needs to be rebased against linux-next (or linux-dm.git's
'for-next') because the code in question has been moved out to dm-rq.c
But I'll gladly take care of it.
Your change seems fine, and in fact my intent was always to have it be
10 msec, see commit: d548b34b062b60
Curious that the initial "HZ / 10" (from Jens' commit 7eaceaccab) wasn't
expressed in terms of msecs either.
Anyway, thanks for the fix!
Mike
> ---
> drivers/md/dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 1b2f96205361..17c63265a205 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2175,7 +2175,7 @@ static void dm_request_fn(struct request_queue *q)
> md_in_flight(md) && rq->bio && rq->bio->bi_vcnt == 1 &&
> md->last_rq_pos == pos && md->last_rq_rw == rq_data_dir(rq)) ||
> (ti->type->busy && ti->type->busy(ti))) {
> - blk_delay_queue(q, HZ / 100);
> + blk_delay_queue(q, 10);
> return;
> }
>
> --
> 2.8.0.rc3.226.g39d4020
>
next prev parent reply other threads:[~2016-07-15 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 13:27 [PATCH] dm: fix parameter to blk_delay_queue() Tahsin Erdogan
2016-07-15 13:59 ` Mike Snitzer [this message]
2016-07-15 14:18 ` Tahsin Erdogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715135905.GA22026@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).