From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations Date: Wed, 28 Sep 2016 11:38:04 -0400 Message-ID: <20160928153804.GA25644@redhat.com> References: <566ABCD9.1060404@users.sourceforge.net> <7c232017-e291-fd2d-5516-26e5150d90df@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7c232017-e291-fd2d-5516-26e5150d90df@users.sourceforge.net> Sender: linux-raid-owner@vger.kernel.org To: SF Markus Elfring Cc: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Shaohua Li , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-raid.ids On Wed, Sep 28 2016 at 11:34am -0400, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 28 Sep 2016 17:25:17 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (10): > Use kcalloc() in crypt_alloc_tfms() > Reduce the scope for a variable in crypt_alloc_tfms() > Rename a jump label in crypt_message() > Delete an unnecessary variable initialisation in crypt_message() > Rename a jump label in crypt_set_key() > Delete an unnecessary variable initialisation in crypt_set_key() > Rename a jump label in crypt_iv_tcw_whitening() > Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr() > Two checks and one function call less in crypt_iv_essiv_ctr() after error detection > Delete unnecessary variable initialisations in crypt_iv_essiv_ctr() > > drivers/md/dm-crypt.c | 51 ++++++++++++++++++++++----------------------------- > 1 file changed, 22 insertions(+), 29 deletions(-) These are _not_ the kind of changes I want to be seeing. Churn in the name of "fine-tuning". Nack.