Re: [PATCH 2/2] md: unblock array if bad blocks have been acknowledged

[Shaohua Li <shli@kernel.org>]

On Mon, Oct 17, 2016 at 04:29:40PM +0200, Tomasz Majchrzak wrote:
> Once external metadata handler acknowledges all bad blocks (by writing
> to rdev 'bad_blocks' sysfs file), it requests to unblock the array.
> Check if all bad blocks are actually acknowledged as there might be a
> race if new bad blocks are notified at the same time. If all bad blocks
> are acknowledged, just unblock the array and continue. If not, ignore
> the request to unblock (do not fail an array). External metadata handler
> is expected to either process remaining bad blocks and try to unblock
> again or remove bad block support for a disk (which will cause disk to
> fail as in no-support case).
> 
> Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
> Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> ---
>  drivers/md/md.c | 43 ++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 36 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index f375d1b..81b4c33 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2629,19 +2629,48 @@ state_store(struct md_rdev *rdev, const char *buf, size_t len)
>  		set_bit(Blocked, &rdev->flags);
>  		err = 0;
>  	} else if (cmd_match(buf, "-blocked")) {
> -		if (!test_bit(Faulty, &rdev->flags) &&
> +		int unblock = 1;
> +
> +		if ((test_bit(ExternalBbl, &rdev->flags) &&
> +			 rdev->badblocks.changed)) {
> +			struct badblocks *bb = &rdev->badblocks;
> +			int ack = 1;
> +
> +			write_seqlock_irq(&bb->lock);
> +			if (bb->unacked_exist) {
> +				u64 *p = bb->page;
> +				int i;
> +
> +				for (i = 0; i < bb->count ; i++) {
> +					if (!BB_ACK(p[i])) {
> +						ack = 0;
> +						break;
> +					}
> +				}
> +				if (ack) {
> +					bb->unacked_exist = 0;
> +					bb->changed = 0;
> +				}
> +			}
> +			write_sequnlock_irq(&bb->lock);
> +		}

shouldn't this part be moved to badblocks.c?

Thanks,
Shaohua