From: Shaohua Li <shli@kernel.org>
To: Guoqing Jiang <gqjiang@suse.com>
Cc: shli@fb.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH] md/bitmap: call bitmap_file_unmap once bitmap_storage_alloc returns -ENOMEM
Date: Fri, 4 Nov 2016 13:19:54 -0700 [thread overview]
Message-ID: <20161104201954.e4vjcsopggm5s53z@kernel.org> (raw)
In-Reply-To: <1477880340-23036-1-git-send-email-gqjiang@suse.com>
On Mon, Oct 31, 2016 at 10:19:00AM +0800, Guoqing Jiang wrote:
> It is possible that bitmap_storage_alloc could return -ENOMEM,
> and some member inside store could be allocated such as filemap.
>
> To avoid memory leak, we need to call bitmap_file_unmap to free
> those members in the bitmap_resize.
>
> Reviewed-by: NeilBrown <neilb@suse.com>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
thanks, applied.
prev parent reply other threads:[~2016-11-04 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 2:19 [PATCH] md/bitmap: call bitmap_file_unmap once bitmap_storage_alloc returns -ENOMEM Guoqing Jiang
2016-11-04 20:19 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104201954.e4vjcsopggm5s53z@kernel.org \
--to=shli@kernel.org \
--cc=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).