From: Shaohua Li <shli@kernel.org>
To: NeilBrown <neilb@suse.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [md PATCH 0/9] replace printk() with pr_*()
Date: Fri, 4 Nov 2016 14:36:48 -0700 [thread overview]
Message-ID: <20161104213648.phh55ov534hkk6py@kernel.org> (raw)
In-Reply-To: <147805657658.23566.1748253447749986766.stgit@noble>
On Wed, Nov 02, 2016 at 02:16:48PM +1100, Neil Brown wrote:
> This series removes all printk() calls from md code, preferring
> pr_warn(), pr_err() etc.
>
> All strings that were split over multiple lines are not joined
> back together because being able to search for a message is more
> important that not having long lines in the code.
> Lots of printk(KERN_DEBUG... are not pr_debug() which means the
> messages won't get printed unless they are explicitly disabled.
>
> I included some rough guidelines on which pr_* to choose in md.c.
> Many things became pr_debug(), most of the rest are pr_warn().
> pr_err() and pr_crit() are used sparingly.
>
> I simplified some code in multipath.c too.
>
> A particular benefit of this is that the various "print_conf()"
> functions are not silent by default.
> On very large arrays (raid10 with hundreds of devices), these can
> be very noisy.
Thanks for doing this, applied.
prev parent reply other threads:[~2016-11-04 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 3:16 [md PATCH 0/9] replace printk() with pr_*() NeilBrown
2016-11-02 3:16 ` [md PATCH 5/9] md/multipath: " NeilBrown
2016-11-02 3:16 ` [md PATCH 4/9] md/linear: " NeilBrown
2016-11-02 3:16 ` [md PATCH 3/9] md/bitmap: change all printk() to pr_*() NeilBrown
2016-11-02 3:16 ` [md PATCH 1/9] md: fix some issues with alloc_disk_sb() NeilBrown
2016-11-02 3:16 ` [md PATCH 2/9] md: change all printk() to pr_err() or pr_warn() etc NeilBrown
2016-11-02 3:16 ` [md PATCH 9/9] md/raid5: change printk() to pr_*() NeilBrown
2016-11-02 3:16 ` [md PATCH 7/9] md/raid1: " NeilBrown
2016-11-02 3:16 ` [md PATCH 8/9] md/raid10: " NeilBrown
2016-11-02 3:16 ` [md PATCH 6/9] md/raid0: replace printk() with pr_*() NeilBrown
2016-11-02 12:36 ` [md PATCH 0/9] " Hannes Reinecke
2016-11-02 21:14 ` NeilBrown
2016-11-04 21:36 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104213648.phh55ov534hkk6py@kernel.org \
--to=shli@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).