From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] md/r5cache: enable IRQs on error path Date: Thu, 24 Nov 2016 14:13:04 +0300 Message-ID: <20161124111304.GI17225@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: kernel-janitors-owner@vger.kernel.org To: Shaohua Li , Song Liu Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-raid.ids We need to re-enable the IRQs here before returning. Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support") Signed-off-by: Dan Carpenter diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c index 2a60ce4..6610134 100644 --- a/drivers/md/raid5-cache.c +++ b/drivers/md/raid5-cache.c @@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf) spin_lock_irqsave(&log->stripe_in_journal_lock, flags); if (list_empty(&conf->log->stripe_in_journal_list)) { /* all stripes flushed */ - spin_unlock(&log->stripe_in_journal_lock); + spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags); return log->next_checkpoint; } sh = list_first_entry(&conf->log->stripe_in_journal_list,