* [patch] md/r5cache: enable IRQs on error path
@ 2016-11-24 11:13 Dan Carpenter
2016-11-28 5:37 ` Shaohua Li
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-11-24 11:13 UTC (permalink / raw)
To: Shaohua Li, Song Liu; +Cc: linux-raid, kernel-janitors
We need to re-enable the IRQs here before returning.
Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 2a60ce4..6610134 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf)
spin_lock_irqsave(&log->stripe_in_journal_lock, flags);
if (list_empty(&conf->log->stripe_in_journal_list)) {
/* all stripes flushed */
- spin_unlock(&log->stripe_in_journal_lock);
+ spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags);
return log->next_checkpoint;
}
sh = list_first_entry(&conf->log->stripe_in_journal_list,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] md/r5cache: enable IRQs on error path
2016-11-24 11:13 [patch] md/r5cache: enable IRQs on error path Dan Carpenter
@ 2016-11-28 5:37 ` Shaohua Li
0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2016-11-28 5:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Song Liu, linux-raid, kernel-janitors
On Thu, Nov 24, 2016 at 02:13:04PM +0300, Dan Carpenter wrote:
> We need to re-enable the IRQs here before returning.
>
> Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 2a60ce4..6610134 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf)
> spin_lock_irqsave(&log->stripe_in_journal_lock, flags);
> if (list_empty(&conf->log->stripe_in_journal_list)) {
> /* all stripes flushed */
> - spin_unlock(&log->stripe_in_journal_lock);
> + spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags);
> return log->next_checkpoint;
> }
> sh = list_first_entry(&conf->log->stripe_in_journal_list,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-28 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 11:13 [patch] md/r5cache: enable IRQs on error path Dan Carpenter
2016-11-28 5:37 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).