From: Shaohua Li <shli@kernel.org>
To: JackieLiu <liuyun01@kylinos.cn>
Cc: shli@fb.com, songliubraving@fb.com, liuzhengyuan@kylinos.cn,
linux-raid@vger.kernel.org
Subject: Re: [PATCH] md/raid5-cache: remove the unnecessary next_cp_seq field from the r5l_log
Date: Tue, 29 Nov 2016 14:37:58 -0800 [thread overview]
Message-ID: <20161129223758.jybulclyeascfuo3@kernel.org> (raw)
In-Reply-To: <20161129031320.9025-1-liuyun01@kylinos.cn>
On Tue, Nov 29, 2016 at 11:13:20AM +0800, JackieLiu wrote:
> The next_cp_seq field is useless, remove it.
applied, thanks!
> Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
> ---
> drivers/md/raid5-cache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 5f817bd..95bd51e 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -113,7 +113,6 @@ struct r5l_log {
> u64 seq; /* log head sequence */
>
> sector_t next_checkpoint;
> - u64 next_cp_seq;
>
> struct mutex io_mutex;
> struct r5l_io_unit *current_io; /* current io_unit accepting new data */
> @@ -1075,7 +1074,6 @@ static bool r5l_complete_finished_ios(struct r5l_log *log)
> break;
>
> log->next_checkpoint = io->log_start;
> - log->next_cp_seq = io->seq;
>
> list_del(&io->log_sibling);
> mempool_free(io, log->io_pool);
> --
> 2.10.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-11-29 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 3:13 [PATCH] md/raid5-cache: remove the unnecessary next_cp_seq field from the r5l_log JackieLiu
2016-11-29 22:37 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129223758.jybulclyeascfuo3@kernel.org \
--to=shli@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=liuzhengyuan@kylinos.cn \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox