* [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly
@ 2016-11-29 3:57 JackieLiu
2016-11-29 21:59 ` Song Liu
2016-11-29 22:40 ` Shaohua Li
0 siblings, 2 replies; 3+ messages in thread
From: JackieLiu @ 2016-11-29 3:57 UTC (permalink / raw)
To: songliubraving; +Cc: liuzhengyuan, linux-raid, JackieLiu
R5c_make_stripe_write_out has set this flag, do not need to set again.
Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
---
drivers/md/raid5-cache.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 95bd51e..aa89de0 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -1247,8 +1247,6 @@ static void r5c_flush_stripe(struct r5conf *conf, struct stripe_head *sh)
atomic_inc(&conf->active_stripes);
r5c_make_stripe_write_out(sh);
- if (!test_and_set_bit(STRIPE_PREREAD_ACTIVE, &sh->state))
- atomic_inc(&conf->preread_active_stripes);
raid5_release_stripe(sh);
}
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly
2016-11-29 3:57 [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly JackieLiu
@ 2016-11-29 21:59 ` Song Liu
2016-11-29 22:40 ` Shaohua Li
1 sibling, 0 replies; 3+ messages in thread
From: Song Liu @ 2016-11-29 21:59 UTC (permalink / raw)
To: JackieLiu; +Cc: liuzhengyuan, linux-raid, shli
On Tue, Nov 29, 2016 at 11:57:30AM +0800, JackieLiu wrote:
> R5c_make_stripe_write_out has set this flag, do not need to set again.
>
> Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
> ---
> drivers/md/raid5-cache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 95bd51e..aa89de0 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1247,8 +1247,6 @@ static void r5c_flush_stripe(struct r5conf *conf, struct stripe_head *sh)
> atomic_inc(&conf->active_stripes);
> r5c_make_stripe_write_out(sh);
>
> - if (!test_and_set_bit(STRIPE_PREREAD_ACTIVE, &sh->state))
> - atomic_inc(&conf->preread_active_stripes);
> raid5_release_stripe(sh);
> }
>
> --
> 2.10.2
>
>
>
Reviewed-by: Song Liu <songliubraving@fb.com>
Thanks for the fix!
Song
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly
2016-11-29 3:57 [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly JackieLiu
2016-11-29 21:59 ` Song Liu
@ 2016-11-29 22:40 ` Shaohua Li
1 sibling, 0 replies; 3+ messages in thread
From: Shaohua Li @ 2016-11-29 22:40 UTC (permalink / raw)
To: JackieLiu; +Cc: songliubraving, liuzhengyuan, linux-raid
On Tue, Nov 29, 2016 at 11:57:30AM +0800, JackieLiu wrote:
> R5c_make_stripe_write_out has set this flag, do not need to set again.
>
> Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
> ---
> drivers/md/raid5-cache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 95bd51e..aa89de0 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1247,8 +1247,6 @@ static void r5c_flush_stripe(struct r5conf *conf, struct stripe_head *sh)
> atomic_inc(&conf->active_stripes);
> r5c_make_stripe_write_out(sh);
>
> - if (!test_and_set_bit(STRIPE_PREREAD_ACTIVE, &sh->state))
> - atomic_inc(&conf->preread_active_stripes);
> raid5_release_stripe(sh);
> }
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-29 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-29 3:57 [PATCH] md/raid5-cache: do not need to set STRIPE_PREREAD_ACTIVE repeatedly JackieLiu
2016-11-29 21:59 ` Song Liu
2016-11-29 22:40 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).