From: Christoph Hellwig <hch@infradead.org>
To: Robert LeBlanc <robert@leblancnet.us>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] Reorganize make_request to clean up code.
Date: Wed, 30 Nov 2016 08:24:53 -0800 [thread overview]
Message-ID: <20161130162453.GA19132@infradead.org> (raw)
In-Reply-To: <20161129230711.9987-1-robert@leblancnet.us>
On Tue, Nov 29, 2016 at 04:07:11PM -0700, Robert LeBlanc wrote:
> This code only runs during a write, so move it to the write section to
> clean up the code.
>
> Signed-off-by: Robert LeBlanc <robert@leblancnet.us>
Can you please just split make_request into one function for reads
and one for writes? There is no shared code at all, so this should be
much cleaner.
prev parent reply other threads:[~2016-11-30 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 23:07 [PATCH] Reorganize make_request to clean up code Robert LeBlanc
2016-11-30 16:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130162453.GA19132@infradead.org \
--to=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=robert@leblancnet.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).