From: Shaohua Li <shli@kernel.org>
To: JackieLiu <liuyun01@kylinos.cn>
Cc: songliubraving@fb.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments
Date: Fri, 16 Dec 2016 12:12:44 -0800 [thread overview]
Message-ID: <20161216201244.6xnckow6t35ruuvd@kernel.org> (raw)
In-Reply-To: <20161213055527.3306-1-liuyun01@kylinos.cn>
On Tue, Dec 13, 2016 at 01:55:27PM +0800, JackieLiu wrote:
> The write-through mode has been returned in front of the function,
> do not need to do it again.
applied, thanks!
> Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
> ---
> drivers/md/raid5-cache.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 6d1a150..4dd8e4e 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -2418,9 +2418,6 @@ void r5c_finish_stripe_write_out(struct r5conf *conf,
> if (do_wakeup)
> wake_up(&conf->wait_for_overlap);
>
> - if (conf->log->r5c_journal_mode == R5C_JOURNAL_MODE_WRITE_THROUGH)
> - return;
> -
> spin_lock_irq(&conf->log->stripe_in_journal_lock);
> list_del_init(&sh->r5c);
> spin_unlock_irq(&conf->log->stripe_in_journal_lock);
> --
> 2.10.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-12-16 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 5:55 [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments JackieLiu
2016-12-16 20:12 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216201244.6xnckow6t35ruuvd@kernel.org \
--to=shli@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).