* [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments
@ 2016-12-13 5:55 JackieLiu
2016-12-16 20:12 ` Shaohua Li
0 siblings, 1 reply; 2+ messages in thread
From: JackieLiu @ 2016-12-13 5:55 UTC (permalink / raw)
To: songliubraving; +Cc: shli, linux-raid, JackieLiu
The write-through mode has been returned in front of the function,
do not need to do it again.
Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
---
drivers/md/raid5-cache.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 6d1a150..4dd8e4e 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -2418,9 +2418,6 @@ void r5c_finish_stripe_write_out(struct r5conf *conf,
if (do_wakeup)
wake_up(&conf->wait_for_overlap);
- if (conf->log->r5c_journal_mode == R5C_JOURNAL_MODE_WRITE_THROUGH)
- return;
-
spin_lock_irq(&conf->log->stripe_in_journal_lock);
list_del_init(&sh->r5c);
spin_unlock_irq(&conf->log->stripe_in_journal_lock);
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments
2016-12-13 5:55 [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments JackieLiu
@ 2016-12-16 20:12 ` Shaohua Li
0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2016-12-16 20:12 UTC (permalink / raw)
To: JackieLiu; +Cc: songliubraving, linux-raid
On Tue, Dec 13, 2016 at 01:55:27PM +0800, JackieLiu wrote:
> The write-through mode has been returned in front of the function,
> do not need to do it again.
applied, thanks!
> Signed-off-by: JackieLiu <liuyun01@kylinos.cn>
> ---
> drivers/md/raid5-cache.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 6d1a150..4dd8e4e 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -2418,9 +2418,6 @@ void r5c_finish_stripe_write_out(struct r5conf *conf,
> if (do_wakeup)
> wake_up(&conf->wait_for_overlap);
>
> - if (conf->log->r5c_journal_mode == R5C_JOURNAL_MODE_WRITE_THROUGH)
> - return;
> -
> spin_lock_irq(&conf->log->stripe_in_journal_lock);
> list_del_init(&sh->r5c);
> spin_unlock_irq(&conf->log->stripe_in_journal_lock);
> --
> 2.10.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-16 20:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 5:55 [PATCH] md/raid5-cache: removes unnecessary write-through mode judgments JackieLiu
2016-12-16 20:12 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).