linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* drivers/md/dm-mpath.c:478: suspicious code ?
@ 2017-01-06 17:52 David Binderman
  2017-01-06 20:08 ` Mike Snitzer
  0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2017-01-06 17:52 UTC (permalink / raw)
  To: agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
	shli@kernel.org, linux-raid@vger.kernel.org,
	linux-kernel@vger.kernel.org

Hello there,

drivers/md/dm-mpath.c:478:19: warning: decrement of a boolean expression [-Wbool-operation]

Source code is

   } while (bypassed--);

Suggest code rework. Maybe a boolean / int type mixup ?

Regards

David Binderman

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: drivers/md/dm-mpath.c:478: suspicious code ?
  2017-01-06 17:52 drivers/md/dm-mpath.c:478: suspicious code ? David Binderman
@ 2017-01-06 20:08 ` Mike Snitzer
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2017-01-06 20:08 UTC (permalink / raw)
  To: David Binderman
  Cc: agk@redhat.com, dm-devel@redhat.com, shli@kernel.org,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org

On Fri, Jan 06 2017 at 12:52pm -0500,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> drivers/md/dm-mpath.c:478:19: warning: decrement of a boolean expression [-Wbool-operation]
> 
> Source code is
> 
>    } while (bypassed--);
> 
> Suggest code rework. Maybe a boolean / int type mixup ?

Yeah, should be cleaned up.

Thanks for reporting this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-06 20:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 17:52 drivers/md/dm-mpath.c:478: suspicious code ? David Binderman
2017-01-06 20:08 ` Mike Snitzer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).