From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@fb.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:SOFTWARE RAID (Multiple Disks) SUPPORT"
<linux-raid@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
NeilBrown <neilb@suse.com>
Subject: Re: [PATCH 4/4] md: fast clone bio in bio_clone_mddev()
Date: Mon, 6 Feb 2017 06:24:51 -0800 [thread overview]
Message-ID: <20170206142451.GA17008@infradead.org> (raw)
In-Reply-To: <CACVXFVNhB5i_5VJ4596ktLRnEM03GhqhZD-x+E_QwK1kZydTJg@mail.gmail.com>
On Mon, Feb 06, 2017 at 06:43:32PM +0800, Ming Lei wrote:
> In theory, ->bio_set still might be NULL in case of failed memory allocation,
> please see md_run().
And that's something that should be fixed. Silently not having mempool
is very bad behavior.
prev parent reply other threads:[~2017-02-06 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 6:22 [PATCH 0/4] md: use bio_clone_fast() Ming Lei
2017-02-05 6:22 ` [PATCH 1/4] block: introduce bio_clone_bioset_partial() Ming Lei
2017-02-05 6:22 ` [PATCH 2/4] md: introduce bio_clone_slow_mddev_partial() Ming Lei
2017-02-06 8:52 ` Christoph Hellwig
2017-02-05 6:22 ` [PATCH 3/4] md/raid1: use bio_clone_slow_mddev_partial in case of write behind Ming Lei
2017-02-05 6:22 ` [PATCH 4/4] md: fast clone bio in bio_clone_mddev() Ming Lei
2017-02-06 8:54 ` Christoph Hellwig
2017-02-06 10:43 ` Ming Lei
2017-02-06 14:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206142451.GA17008@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).