From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/4] md: fast clone bio in bio_clone_mddev() Date: Mon, 6 Feb 2017 06:24:51 -0800 Message-ID: <20170206142451.GA17008@infradead.org> References: <1486275733-7268-1-git-send-email-tom.leiming@gmail.com> <1486275733-7268-5-git-send-email-tom.leiming@gmail.com> <20170206085433.GB6411@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ming Lei Cc: Christoph Hellwig , Shaohua Li , Jens Axboe , Linux Kernel Mailing List , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" , linux-block , NeilBrown List-Id: linux-raid.ids On Mon, Feb 06, 2017 at 06:43:32PM +0800, Ming Lei wrote: > In theory, ->bio_set still might be NULL in case of failed memory allocation, > please see md_run(). And that's something that should be fixed. Silently not having mempool is very bad behavior.