From: Vinod Koul <vinod.koul@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Anup Patel <anup.patel@broadcom.com>,
Rameshwar Prasad Sahu <rsahu@apm.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
dmaengine@vger.kernel.org, Anatolij Gustschin <agust@denx.de>,
Saeed Bishara <saeed.bishara@gmail.com>
Subject: Re: [PATCH] async_tx: deprecate broken support for channel switching
Date: Thu, 16 Feb 2017 10:09:24 +0530 [thread overview]
Message-ID: <20170216043924.GQ2843@localhost> (raw)
In-Reply-To: <148721292971.19343.10618932473668163270.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Feb 15, 2017 at 06:42:09PM -0800, Dan Williams wrote:
> Back in 2011, Russell pointed out that the "async_tx channel switch"
> capability was violating expectations of the dma mapping api [1]. At the
> time the existing uses were reviewed as still usable, but that longer
> term we needed a rework of the raid offload implementation. While some
> of the framework for a fixed implementation was introduced in 2012 [2],
> the wider rewrite never materialized.
>
> There continues to be interest in raid offload with new dma/raid engine
> drivers being submitted. Those drivers must not build on top of the
> broken channel switching capability.
>
> Prevent async_tx from using an offload engine if the channel switching
> capability is enabled. This still allows the engine to be used for other
> purposes, but the broken way async_tx uses these engines for raid will
> be disabled. For configurations where this causes a performance
> regression the only solution is to start the work of eliminating the
> async_tx api and moving channel management into the raid code directly
> where it can manage marshalling an operation stream between multiple dma
> channels.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2017-02-16 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 2:42 [PATCH] async_tx: deprecate broken support for channel switching Dan Williams
2017-02-16 4:39 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216043924.GQ2843@localhost \
--to=vinod.koul@intel.com \
--cc=agust@denx.de \
--cc=anup.patel@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rsahu@apm.com \
--cc=saeed.bishara@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).