From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [PATCH v2 05/13] md: raid1: simplify r1buf_pool_free() Date: Thu, 2 Mar 2017 09:49:42 -0800 Message-ID: <20170302174942.ad3lsrqgvi2erkrl@kernel.org> References: <1488296503-4987-1-git-send-email-tom.leiming@gmail.com> <1488296503-4987-6-git-send-email-tom.leiming@gmail.com> <20170228233105.npftquaf3fr5sfpl@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org To: Ming Lei Cc: Jens Axboe , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" , linux-block , Christoph Hellwig List-Id: linux-raid.ids On Thu, Mar 02, 2017 at 10:11:54AM +0800, Ming Lei wrote: > Hi Shaohua, > > On Wed, Mar 1, 2017 at 7:31 AM, Shaohua Li wrote: > > On Tue, Feb 28, 2017 at 11:41:35PM +0800, Ming Lei wrote: > >> This patch gets each page's reference of each bio for resync, > >> then r1buf_pool_free() gets simplified a lot. > >> > >> The same policy has been taken in raid10's buf pool allocation/free > >> too. > > > > We are going to delete the code, this simplify isn't really required. > > Could you explain it a bit? Or I can put this patch into this patchset if you > can provide one? I mean you will replace the code soon, with the resync_pages stuff. So I thought this isn't really required. Thanks, Shaohua