From: Shaohua Li <shli@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-raid@vger.kernel.org, shli@fb.com, neilb@suse.com,
kernel-team@fb.com, dan.j.williams@intel.com, hch@infradead.org
Subject: Re: [PATCH] md/r5cache: fix set_syndrome_sources()
Date: Tue, 14 Mar 2017 09:52:33 -0700 [thread overview]
Message-ID: <20170314165233.p7wef5qxyosxe5hm@kernel.org> (raw)
In-Reply-To: <20170313204435.1732089-1-songliubraving@fb.com>
On Mon, Mar 13, 2017 at 01:44:35PM -0700, Song Liu wrote:
> With srctype == SYNDROME_SRC_WRITTEN, we need include both
> dev with non-null ->written and dev with R5_InJournal.
Thanks, applied. I'll add this to stable
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> drivers/md/raid5.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 1c554a8..88cc898 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -1499,7 +1499,8 @@ static int set_syndrome_sources(struct page **srcs,
> (test_bit(R5_Wantdrain, &dev->flags) ||
> test_bit(R5_InJournal, &dev->flags))) ||
> (srctype == SYNDROME_SRC_WRITTEN &&
> - dev->written)) {
> + (dev->written ||
> + test_bit(R5_InJournal, &dev->flags)))) {
> if (test_bit(R5_InJournal, &dev->flags))
> srcs[slot] = sh->dev[i].orig_page;
> else
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-03-14 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 20:44 [PATCH] md/r5cache: fix set_syndrome_sources() Song Liu
2017-03-13 20:58 ` Dan Williams
2017-03-13 21:20 ` Song Liu
2017-03-14 16:52 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314165233.p7wef5qxyosxe5hm@kernel.org \
--to=shli@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).