From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: dm crypt: remove an impossible condition Date: Sat, 18 Mar 2017 07:14:22 +0300 Message-ID: <20170318041422.GC4102@mwanda> References: <20170317204655.GA28261@mwanda> <20170317213819.GC6475@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170317213819.GC6475@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: kernel-janitors@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, Shaohua Li , Milan Broz , Alasdair Kergon List-Id: linux-raid.ids On Fri, Mar 17, 2017 at 05:38:19PM -0400, Mike Snitzer wrote: > On Fri, Mar 17 2017 at 4:46pm -0400, > Dan Carpenter wrote: > > > Static checkers complain that it doesn't make sense to check if "sval" > > is NULL. The intention was to check if strchr() returned NULL, but in > > that situation "sval" would be "NULL + 1" so the check doesn't work. We > > know from the sscanf() that there is a ':' character in the string so > > the check is unnecessary and can be removed. > > > > Now that the check doesn't depend on "sval" it can be moved earlier > > for readability. > > > > Signed-off-by: Dan Carpenter > > Thanks Dan, I've folded this fix into the original commit, see: > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.12&id=cf22cd5f3afe7335afee5659f7450000e8fa2a15 > > I didn't add your Signed-off-by though, I can backfill that if you > like.. it is just I didn't want to taint you with all the extensive > changes in that commit. That's fine, thanks. Sign-off isn't really the appropriate tag anyway... regards, dan carpenter