* [PATCH] raid5-ppl: silence a misleading warning message
@ 2017-03-21 20:43 Dan Carpenter
2017-03-23 12:00 ` Artur Paszkiewicz
2017-03-24 5:37 ` Shaohua Li
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-03-21 20:43 UTC (permalink / raw)
To: Shaohua Li, Artur Paszkiewicz; +Cc: linux-raid, kernel-janitors
The "need_cache_flush" variable is never set to false. When the
variable is true that means we print a warning message at the end of
the function.
Fixes: 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index 27bad3e2d7ce..86ea9addb51a 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf)
struct mddev *mddev = conf->mddev;
int ret = 0;
int i;
- bool need_cache_flush;
+ bool need_cache_flush = false;
pr_debug("md/raid:%s: enabling distributed Partial Parity Log\n",
mdname(conf->mddev));
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] raid5-ppl: silence a misleading warning message
2017-03-21 20:43 [PATCH] raid5-ppl: silence a misleading warning message Dan Carpenter
@ 2017-03-23 12:00 ` Artur Paszkiewicz
2017-03-24 5:37 ` Shaohua Li
1 sibling, 0 replies; 3+ messages in thread
From: Artur Paszkiewicz @ 2017-03-23 12:00 UTC (permalink / raw)
To: Dan Carpenter, Shaohua Li; +Cc: linux-raid, kernel-janitors
On 03/21/2017 09:43 PM, Dan Carpenter wrote:
> The "need_cache_flush" variable is never set to false. When the
> variable is true that means we print a warning message at the end of
> the function.
>
> Fixes: 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks. I thought gcc would warn about such issues, I'll
have to be more careful.
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] raid5-ppl: silence a misleading warning message
2017-03-21 20:43 [PATCH] raid5-ppl: silence a misleading warning message Dan Carpenter
2017-03-23 12:00 ` Artur Paszkiewicz
@ 2017-03-24 5:37 ` Shaohua Li
1 sibling, 0 replies; 3+ messages in thread
From: Shaohua Li @ 2017-03-24 5:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Artur Paszkiewicz, linux-raid, kernel-janitors
On Tue, Mar 21, 2017 at 11:43:05PM +0300, Dan Carpenter wrote:
> The "need_cache_flush" variable is never set to false. When the
> variable is true that means we print a warning message at the end of
> the function.
>
> Fixes: 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
applied, thanks!
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index 27bad3e2d7ce..86ea9addb51a 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf)
> struct mddev *mddev = conf->mddev;
> int ret = 0;
> int i;
> - bool need_cache_flush;
> + bool need_cache_flush = false;
>
> pr_debug("md/raid:%s: enabling distributed Partial Parity Log\n",
> mdname(conf->mddev));
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-24 5:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 20:43 [PATCH] raid5-ppl: silence a misleading warning message Dan Carpenter
2017-03-23 12:00 ` Artur Paszkiewicz
2017-03-24 5:37 ` Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).