From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [PATCH] raid5-ppl: silence a misleading warning message Date: Thu, 23 Mar 2017 22:37:56 -0700 Message-ID: <20170324053756.o6efazfnv7fc6ihj@kernel.org> References: <20170321204305.GC22118@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170321204305.GC22118@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Artur Paszkiewicz , linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-raid.ids On Tue, Mar 21, 2017 at 11:43:05PM +0300, Dan Carpenter wrote: > The "need_cache_flush" variable is never set to false. When the > variable is true that means we print a warning message at the end of > the function. > > Fixes: 3418d036c81d ("raid5-ppl: Partial Parity Log write logging implementation") > Signed-off-by: Dan Carpenter applied, thanks! > diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c > index 27bad3e2d7ce..86ea9addb51a 100644 > --- a/drivers/md/raid5-ppl.c > +++ b/drivers/md/raid5-ppl.c > @@ -1070,7 +1070,7 @@ int ppl_init_log(struct r5conf *conf) > struct mddev *mddev = conf->mddev; > int ret = 0; > int i; > - bool need_cache_flush; > + bool need_cache_flush = false; > > pr_debug("md/raid:%s: enabling distributed Partial Parity Log\n", > mdname(conf->mddev));