From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 15/24] block: remove blk_part_pack_uuid Date: Wed, 31 May 2017 21:39:48 +0200 Message-ID: <20170531193948.GB6906@lst.de> References: <20170531161826.23243-1-hch@lst.de> <20170531161826.23243-16-hch@lst.de> <1496254594.28981.37.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1496254594.28981.37.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steven Whitehouse , David Howells , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaohua Li , Christoph Hellwig List-Id: linux-raid.ids On Wed, May 31, 2017 at 09:16:34PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-31 at 18:18 +0200, Christoph Hellwig wrote: > > This helper was only used by IMA of all things, which would get > > spurious > > errors if CONFIG_BLOCK is disabled.=A0=A0Just opencode the call there. > = > > - result =3D blk_part_pack_uuid(args[0].from, > > - =A0=A0=A0=A0entry->fsuuid); > > + result =3D uuid_to_bin(args[0].from, (uuid_t > > *)&entry->fsuuid); > > = > = > uuid_parse() ? Yes. I fixed this up, but it seems like I didn't squash it into the right patch..