linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] raid5-ppl: use BIOSET_NEED_BVECS when creating bioset
@ 2017-07-11 14:16 Artur Paszkiewicz
  2017-07-12 16:25 ` Shaohua Li
  0 siblings, 1 reply; 2+ messages in thread
From: Artur Paszkiewicz @ 2017-07-11 14:16 UTC (permalink / raw)
  To: shli; +Cc: linux-raid, Artur Paszkiewicz

This bioset is used for allocating bios with nr_iovecs > 0 so this flag
must be set.

Fixes: 011067b05668 ("blk: replace bioset_create_nobvec() with a flags arg to bioset_create()")
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
---
 drivers/md/raid5-ppl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index 77cce3573aa8..44ad5baf3206 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1150,7 +1150,7 @@ int ppl_init_log(struct r5conf *conf)
 		goto err;
 	}
 
-	ppl_conf->bs = bioset_create(conf->raid_disks, 0, 0);
+	ppl_conf->bs = bioset_create(conf->raid_disks, 0, BIOSET_NEED_BVECS);
 	if (!ppl_conf->bs) {
 		ret = -ENOMEM;
 		goto err;
-- 
2.13.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] raid5-ppl: use BIOSET_NEED_BVECS when creating bioset
  2017-07-11 14:16 [PATCH] raid5-ppl: use BIOSET_NEED_BVECS when creating bioset Artur Paszkiewicz
@ 2017-07-12 16:25 ` Shaohua Li
  0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2017-07-12 16:25 UTC (permalink / raw)
  To: Artur Paszkiewicz; +Cc: linux-raid

On Tue, Jul 11, 2017 at 04:16:24PM +0200, Artur Paszkiewicz wrote:
> This bioset is used for allocating bios with nr_iovecs > 0 so this flag
> must be set.
> 
> Fixes: 011067b05668 ("blk: replace bioset_create_nobvec() with a flags arg to bioset_create()")
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>

Applied, thanks!
> ---
>  drivers/md/raid5-ppl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index 77cce3573aa8..44ad5baf3206 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -1150,7 +1150,7 @@ int ppl_init_log(struct r5conf *conf)
>  		goto err;
>  	}
>  
> -	ppl_conf->bs = bioset_create(conf->raid_disks, 0, 0);
> +	ppl_conf->bs = bioset_create(conf->raid_disks, 0, BIOSET_NEED_BVECS);
>  	if (!ppl_conf->bs) {
>  		ret = -ENOMEM;
>  		goto err;
> -- 
> 2.13.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-12 16:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-11 14:16 [PATCH] raid5-ppl: use BIOSET_NEED_BVECS when creating bioset Artur Paszkiewicz
2017-07-12 16:25 ` Shaohua Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).